Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Unified Diff: ppapi/cpp/extensions/dev/socket_dev.h

Issue 13985026: Add a default constructor for VarArrayBuffer, so that it can be used by ext::DictField. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ppapi/cpp/extensions/dev/socket_dev.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/cpp/extensions/dev/socket_dev.h
diff --git a/ppapi/cpp/extensions/dev/socket_dev.h b/ppapi/cpp/extensions/dev/socket_dev.h
index 5d2e5be4a990f0baaa45d2af767b76034c6c78d8..098bb01730b5b2c0da1043848918dcd21a7a5dd2 100644
--- a/ppapi/cpp/extensions/dev/socket_dev.h
+++ b/ppapi/cpp/extensions/dev/socket_dev.h
@@ -96,9 +96,7 @@ class ReadInfo_Dev : public internal::OutputObjectBase {
static const char* const kData;
DictField<int32_t> result_code;
- // TODO(yzshen): It is more natural to use VarArrayBuffer, but it doesn't have
- // a default constructor currently.
- DictField<Var> data;
+ DictField<VarArrayBuffer> data;
};
class WriteInfo_Dev : public internal::OutputObjectBase {
@@ -130,7 +128,7 @@ class RecvFromInfo_Dev : public internal::OutputObjectBase {
static const char* const kPort;
DictField<int32_t> result_code;
- DictField<Var> data;
+ DictField<VarArrayBuffer> data;
DictField<std::string> address;
DictField<int32_t> port;
};
@@ -199,14 +197,14 @@ class Socket_Dev {
const Optional<int32_t>& buffer_size,
const CompletionCallbackWithOutput<ReadInfo_Dev>& callback);
int32_t Write(int32_t socket_id,
- const Var& data,
+ const VarArrayBuffer& data,
const CompletionCallbackWithOutput<WriteInfo_Dev>& callback);
int32_t RecvFrom(
int32_t socket_id,
const Optional<int32_t>& buffer_size,
const CompletionCallbackWithOutput<RecvFromInfo_Dev>& callback);
int32_t SendTo(int32_t socket_id,
- const Var& data,
+ const VarArrayBuffer& data,
const std::string& address,
int32_t port,
const CompletionCallbackWithOutput<WriteInfo_Dev>& callback);
« no previous file with comments | « no previous file | ppapi/cpp/extensions/dev/socket_dev.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698