Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 1398483004: Remove locale files not needed by sync_unit_tests. (Closed)

Created:
5 years, 2 months ago by ghost stip (do not use)
Modified:
5 years, 2 months ago
Reviewers:
jbudorick, pavely
CC:
chromium-reviews, tim+watch_chromium.org, pvalenzuela+watch_chromium.org, maxbogue+watch_chromium.org, plaree+watch_chromium.org, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove locale files not needed by sync_unit_tests. BUG=542429 TBR=jbudorick@chromium.org Committed: https://crrev.com/213b8fa83f28784f2d96ffa58bd526fd31943d00 Cr-Commit-Position: refs/heads/master@{#353884}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Remove in GN too. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -11 lines) Patch
M sync/BUILD.gn View 1 1 chunk +0 lines, -4 lines 0 comments Download
M sync/sync_unit_tests.isolate View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
ghost stip (do not use)
Hopefully this will un-purple our builds.
5 years, 2 months ago (2015-10-12 22:19:55 UTC) #2
jbudorick
https://codereview.chromium.org/1398483004/diff/1/sync/sync_unit_tests.isolate File sync/sync_unit_tests.isolate (left): https://codereview.chromium.org/1398483004/diff/1/sync/sync_unit_tests.isolate#oldcode9 sync/sync_unit_tests.isolate:9: '<(PRODUCT_DIR)/locales/en-US.pak', If we can remove it from here, we ...
5 years, 2 months ago (2015-10-12 22:23:41 UTC) #3
pavely
lgtm % make corresponding change in gn file. I don't think we use strings or ...
5 years, 2 months ago (2015-10-12 23:09:54 UTC) #4
ghost stip (do not use)
TBRing to see if it clears up the chromium.swarm bot
5 years, 2 months ago (2015-10-13 21:30:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1398483004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1398483004/20001
5 years, 2 months ago (2015-10-13 21:31:16 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-13 22:48:35 UTC) #9
commit-bot: I haz the power
5 years, 2 months ago (2015-10-13 22:49:57 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/213b8fa83f28784f2d96ffa58bd526fd31943d00
Cr-Commit-Position: refs/heads/master@{#353884}

Powered by Google App Engine
This is Rietveld 408576698