chrome/android/java/res/layout/new_tab_page.xml - Issue 1398423002: Add progressbar to animated doodle

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/res/layout/new_tab_page.xml

Issue 1398423002: Add progressbar to animated doodle (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/res/layout/eb_main_content.xml ('k') | chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkContentView.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/widget/LoadingView.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/res/layout/new_tab_page.xml

diff --git a/chrome/android/java/res/layout/new_tab_page.xml b/chrome/android/java/res/layout/new_tab_page.xml

index 7ffd32276eadc2a1dfb4e06545fa33a43da0497e..20415ed3439f377417a970b96fab7edcc5a184ca 100644

--- a/chrome/android/java/res/layout/new_tab_page.xml

+++ b/chrome/android/java/res/layout/new_tab_page.xml

@@ -43,15 +43,27 @@

android:visibility="invisible" />

- <org.chromium.chrome.browser.ntp.LogoView

- android:id="@+id/search_provider_logo"

+ <FrameLayout

android:layout_width="wrap_content"

- android:layout_height="@dimen/ntp_logo_height"

- android:layout_marginStart="16dp"

- android:layout_marginEnd="16dp"

- android:layout_marginTop="26dp"

- android:layout_marginBottom="30dp"

- android:src="@drawable/google_logo" />

+ android:layout_height="wrap_content" >

+ <org.chromium.chrome.browser.ntp.LogoView

newt (away) 2015/10/13 05:24:59 You could just make the LogoView extend FrameLayou

Ian Wen 2015/10/26 22:45:37 Done.

+ android:id="@+id/search_provider_logo"

+ android:layout_width="wrap_content"

+ android:layout_height="@dimen/ntp_logo_height"

+ android:layout_marginBottom="30dp"

+ android:layout_marginEnd="16dp"

+ android:layout_marginStart="16dp"

+ android:layout_marginTop="26dp"

+ android:src="@drawable/google_logo" />

+ <org.chromium.chrome.browser.widget.LoadingView

newt (away) 2015/10/13 05:24:59 don't you need to add a ProgressBar inside the Loa

Ian Wen 2015/10/26 22:45:37 Done.

+ android:id="@+id/loading_view"

+ android:layout_width="wrap_content"

+ android:layout_height="wrap_content"

+ android:layout_gravity="center" />

+ </FrameLayout>

<LinearLayout