Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Unified Diff: remoting/host/screen_resolution_unittest.cc

Issue 13983010: Use webrtc::DesktopCapturer for screen capturer implementation. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/host/screen_resolution.cc ('k') | remoting/host/video_scheduler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/host/screen_resolution_unittest.cc
diff --git a/remoting/host/screen_resolution_unittest.cc b/remoting/host/screen_resolution_unittest.cc
index dce7bc0cd2c7defa0c032a2f8ec3efdfb7e7dfc0..01de134b9690f6a006afd7214e079f7ed253b8d6 100644
--- a/remoting/host/screen_resolution_unittest.cc
+++ b/remoting/host/screen_resolution_unittest.cc
@@ -12,69 +12,38 @@
namespace remoting {
TEST(ScreenResolutionTest, Empty) {
- ScreenResolution resolution;
- EXPECT_TRUE(resolution.IsEmpty());
+ ScreenResolution resolution1(
+ webrtc::DesktopSize(100, 100), webrtc::DesktopVector(10, 10));
+ EXPECT_FALSE(resolution1.IsEmpty());
- resolution.dimensions_.set(-1, 0);
- EXPECT_TRUE(resolution.IsEmpty());
+ ScreenResolution resolution2(
+ webrtc::DesktopSize(), webrtc::DesktopVector(10, 10));
+ EXPECT_TRUE(resolution2.IsEmpty());
- resolution.dimensions_.set(0, -1);
- EXPECT_TRUE(resolution.IsEmpty());
-
- resolution.dimensions_.set(-1, -1);
- EXPECT_TRUE(resolution.IsEmpty());
-
- resolution.dpi_.set(-1, 0);
- EXPECT_TRUE(resolution.IsEmpty());
-
- resolution.dpi_.set(0, -1);
- EXPECT_TRUE(resolution.IsEmpty());
-
- resolution.dpi_.set(-1, -1);
- EXPECT_TRUE(resolution.IsEmpty());
-}
-
-TEST(ScreenResolutionTest, Invalid) {
- ScreenResolution resolution;
- EXPECT_TRUE(resolution.IsValid());
-
- resolution.dimensions_.set(-1, 0);
- EXPECT_FALSE(resolution.IsValid());
-
- resolution.dimensions_.set(0, -1);
- EXPECT_FALSE(resolution.IsValid());
-
- resolution.dimensions_.set(-1, -1);
- EXPECT_FALSE(resolution.IsValid());
-
- resolution.dpi_.set(-1, 0);
- EXPECT_FALSE(resolution.IsValid());
-
- resolution.dpi_.set(0, -1);
- EXPECT_FALSE(resolution.IsValid());
-
- resolution.dpi_.set(-1, -1);
- EXPECT_FALSE(resolution.IsValid());
+ ScreenResolution resolution3(
+ webrtc::DesktopSize(1, 1), webrtc::DesktopVector(0, 0));
+ EXPECT_TRUE(resolution3.IsEmpty());
}
TEST(ScreenResolutionTest, Scaling) {
ScreenResolution resolution(
- SkISize::Make(100, 100), SkIPoint::Make(10, 10));
+ webrtc::DesktopSize(100, 100), webrtc::DesktopVector(10, 10));
- EXPECT_EQ(resolution.ScaleDimensionsToDpi(SkIPoint::Make(5, 5)),
- SkISize::Make(50, 50));
+ EXPECT_TRUE(webrtc::DesktopSize(50, 50).equals(
+ resolution.ScaleDimensionsToDpi(webrtc::DesktopVector(5, 5))));
- EXPECT_EQ(resolution.ScaleDimensionsToDpi(SkIPoint::Make(20, 20)),
- SkISize::Make(200, 200));
+ EXPECT_TRUE(webrtc::DesktopSize(200, 200).equals(
+ resolution.ScaleDimensionsToDpi(webrtc::DesktopVector(20, 20))));
}
TEST(ScreenResolutionTest, ScalingSaturation) {
ScreenResolution resolution(
- SkISize::Make(10000000, 1000000), SkIPoint::Make(1, 1));
+ webrtc::DesktopSize(10000000, 1000000), webrtc::DesktopVector(1, 1));
- EXPECT_EQ(resolution.ScaleDimensionsToDpi(SkIPoint::Make(1000000, 1000000)),
- SkISize::Make(std::numeric_limits<int32>::max(),
- std::numeric_limits<int32>::max()));
+ int32 max_int = std::numeric_limits<int32>::max();
+ EXPECT_TRUE(webrtc::DesktopSize(max_int, max_int).equals(
+ resolution.ScaleDimensionsToDpi(
+ webrtc::DesktopVector(1000000, 1000000))));
}
} // namespace remoting
« no previous file with comments | « remoting/host/screen_resolution.cc ('k') | remoting/host/video_scheduler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698