Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 13982022: MediaStream API: Removing LocalMediaStream (Closed)

Created:
7 years, 8 months ago by Tommy Widenflycht
Modified:
7 years, 8 months ago
CC:
blink-reviews, jeez
Visibility:
Public.

Description

MediaStream API: Removing LocalMediaStream The subclass LocalMediaStream have been removed from the getusermedia specification: http://dev.w3.org/2011/webrtc/editor/getusermedia.html The stop method will be moved temporarily to MediaStream until MediaStreamTrack has been updated. This patch has been committed and rolled out due to a failing test; this has been corrected and the problem turned out to be another API change that I had included by mistake (removed the deprecated MediaStream::label). https://codereview.chromium.org/14188039/ BUG=233545 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=149107

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -267 lines) Patch
D LayoutTests/fast/mediastream/LocalMediaStream-onended.html View 1 chunk +0 lines, -54 lines 0 comments Download
D LayoutTests/fast/mediastream/LocalMediaStream-onended-expected.txt View 1 chunk +0 lines, -12 lines 0 comments Download
M LayoutTests/fast/mediastream/MediaStream-onended.html View 1 chunk +23 lines, -4 lines 0 comments Download
M LayoutTests/fast/mediastream/MediaStream-onended-expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/dom/EventTarget.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/EventTargetFactory.in View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/platform/mediastream/MediaStreamDescriptor.h View 2 chunks +3 lines, -2 lines 0 comments Download
D Source/modules/mediastream/LocalMediaStream.h View 1 chunk +0 lines, -57 lines 0 comments Download
D Source/modules/mediastream/LocalMediaStream.cpp View 1 chunk +0 lines, -72 lines 0 comments Download
D Source/modules/mediastream/LocalMediaStream.idl View 1 chunk +0 lines, -31 lines 0 comments Download
M Source/modules/mediastream/MediaStream.h View 2 chunks +1 line, -2 lines 0 comments Download
M Source/modules/mediastream/MediaStream.cpp View 3 chunks +11 lines, -2 lines 0 comments Download
M Source/modules/mediastream/MediaStream.idl View 2 chunks +1 line, -1 line 0 comments Download
M Source/modules/mediastream/NavigatorUserMediaSuccessCallback.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/mediastream/NavigatorUserMediaSuccessCallback.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediastream/UserMediaRequest.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/mediastream/UserMediaRequest.cpp View 2 chunks +2 lines, -11 lines 0 comments Download
M Source/modules/modules.gypi View 2 chunks +0 lines, -3 lines 0 comments Download
M Source/modules/webaudio/AudioContext.cpp View 1 chunk +9 lines, -8 lines 0 comments Download
M Source/modules/webaudio/MediaStreamAudioDestinationNode.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Tommy Widenflycht
7 years, 8 months ago (2013-04-25 12:32:20 UTC) #1
Tommy Widenflycht
7 years, 8 months ago (2013-04-25 14:16:56 UTC) #2
jochen (gone - plz use gerrit)
lgtm
7 years, 8 months ago (2013-04-25 14:21:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tommyw@chromium.org/13982022/1
7 years, 8 months ago (2013-04-25 14:24:09 UTC) #4
commit-bot: I haz the power
7 years, 8 months ago (2013-04-25 14:24:43 UTC) #5
Message was sent while issue was closed. 
Change committed as 149107

Powered by Google App Engine
This is Rietveld 408576698