Fix issue with login items getting recreated.

Fix issue with login items getting recreated.

Added code to track whether chrome has created a login item so we know if it is
safe to delete it and can avoid re-creating it. This flag is also used to do a
better job of determining if a user has deleted the login item.

BUG=140017
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193922

[Andrew T Wilson (Slow), 2013-04-10 16:49:41]

PTAL.

[Andrew T Wilson (Slow), 2013-04-11 15:59:44]

Sailesh, can you take a look at this (since you expressed interest in the bug)?
Dmitry is OOO this week at an offsite.

[sail, 2013-04-11 16:12:29]

lgtm

https://codereview.chromium.org/13982009/diff/1/chrome/browser/background/bac...
File chrome/browser/background/background_mode_manager_mac.mm (right):

https://codereview.chromium.org/13982009/diff/1/chrome/browser/background/bac...
chrome/browser/background/background_mode_manager_mac.mm:83: if
(CommandLine::ForCurrentProcess()->HasSwitch(switches::kUserDataDir))
The user data directory has nothing to do with default profile. I don't think
this line does what you think it does.

https://codereview.chromium.org/13982009/diff/1/chrome/browser/background/bac...
chrome/browser/background/background_mode_manager_mac.mm:111: // every create
another one.
typo? "don't every"

https://codereview.chromium.org/13982009/diff/1/chrome/common/pref_names.cc
File chrome/common/pref_names.cc (right):

https://codereview.chromium.org/13982009/diff/1/chrome/common/pref_names.cc#n...
chrome/common/pref_names.cc:2182: // Set to true if the user removed our login
item so we should not create a new
comment should explain the difference between this and |kUserRemovedLoginItem|

[Andrew T Wilson (Slow), 2013-04-12 09:52:21]

https://codereview.chromium.org/13982009/diff/1/chrome/browser/background/bac...
File chrome/browser/background/background_mode_manager_mac.mm (right):

https://codereview.chromium.org/13982009/diff/1/chrome/browser/background/bac...
chrome/browser/background/background_mode_manager_mac.mm:83: if
(CommandLine::ForCurrentProcess()->HasSwitch(switches::kUserDataDir))
On 2013/04/11 16:12:29, sail wrote:
> The user data directory has nothing to do with default profile. I don't think
> this line does what you think it does.

Yeah, the comment was wrong (predated multi-profile). Fixed it.

https://codereview.chromium.org/13982009/diff/1/chrome/browser/background/bac...
chrome/browser/background/background_mode_manager_mac.mm:111: // every create
another one.
On 2013/04/11 16:12:29, sail wrote:
> typo? "don't every"

Done.

https://codereview.chromium.org/13982009/diff/1/chrome/common/pref_names.cc
File chrome/common/pref_names.cc (right):

https://codereview.chromium.org/13982009/diff/1/chrome/common/pref_names.cc#n...
chrome/common/pref_names.cc:2182: // Set to true if the user removed our login
item so we should not create a new
On 2013/04/11 16:12:29, sail wrote:
> comment should explain the difference between this and |kUserRemovedLoginItem|

Done.

[commit-bot: I haz the power, 2013-04-12 09:52:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/atwilson@chromium.org/13982009/18001

[commit-bot: I haz the power, 2013-04-12 14:17:12]

Change committed as 193922