Start incorporating the ARM integrated assembler.

src/IceTargetLowering.h

 //===- subzero/src/IceTargetLowering.h - Lowering interface -----*- C++ -*-===//
 //
 //                        The Subzero Code Generator
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 ///
 /// \file
@@ skipping 10 matching lines @@
 #ifndef SUBZERO_SRC_ICETARGETLOWERING_H
 #define SUBZERO_SRC_ICETARGETLOWERING_H
 
 #include "IceDefs.h"
 #include "IceInst.h" // for the names of the Inst subtypes
 #include "IceOperand.h"
 #include "IceTypes.h"
 
 namespace Ice {
 
+// UnimplementedError is defined as a macro so that we can get actual line
+// numbers.
+#define UnimplementedError(Flags)                                              \
+  do {                                                                         \
+    if (!static_cast<const ClFlags &>(Flags).getSkipUnimplemented()) {         \

[Jim Stichnoth, 2015/10/08 23:50:41]

Do you really need the cast here?

For proper macro safety, you should probably use ((Flags)), though I guess only
one level of parentheses is needed if you drop the cast.

[John, 2015/10/09 12:12:24]

I'll reply on his behalf, for this is my fault.

Regarding the cast, no you don't need it, but it prevents that the macro is used
with anything that exports a getSkipUnimplemented() method. Think "poor man's
type safety."

Regarding the parenthesis, I think

static_cast<>(Flags)

and

static_cast<>((Flags))

are the same. You just wrap macro parameters to prevent associativity issues,
e.g.,

#define TIMES_10(s) (s * 10)

cout << TIMES_10(a + b)  // oops, this is cout << (a + b * 10);

Given that the cast already includes the parenthesis, this should be fine.

[Karl, 2015/10/09 19:08:18]

Acknowledged.

[Jim Stichnoth, 2015/10/09 20:05:44]

I guess I was thinking of the case where the "Flags" macro arg is instantiated
as "A,B" and then substitution makes it parse as two function arguments instead
of a comma expression.  However, I guess you can't really even pass in a comma
in a macro arg unless the whole arg is inside parentheses, so I guess my
argument is moot.

+      /* Use llvm_unreachable instead of report_fatal_error, which gives       \
+         better stack traces. */                                               \
+      llvm_unreachable("Not yet implemented");                                 \
+      abort();                                                                 \
+    }                                                                          \
+  } while (0)
+
 /// LoweringContext makes it easy to iterate through non-deleted instructions in
 /// a node, and insert new (lowered) instructions at the current point. Along
 /// with the instruction list container and associated iterators, it holds the
 /// current node, which is needed when inserting new instructions in order to
 /// track whether variables are used as single-block or multi-block.
 class LoweringContext {
   LoweringContext(const LoweringContext &) = delete;
   LoweringContext &operator=(const LoweringContext &) = delete;
 
 public:
@@ skipping 420 matching lines @@
   virtual void lower() {}
 
 protected:
   explicit TargetHeaderLowering(GlobalContext *Ctx) : Ctx(Ctx) {}
   GlobalContext *Ctx;
 };
 
 } // end of namespace Ice
 
 #endif // SUBZERO_SRC_ICETARGETLOWERING_H