Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3158)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/cocoa/browser_window_cocoa.mm

Issue 13979003: Win: Display a native bubble (instead of the JS one) after the web signin flow. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove unused imports. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/cocoa/browser_window_cocoa.h ('k') | chrome/browser/ui/gtk/browser_window_gtk.h » ('j') | chrome/browser/ui/views/sync/one_click_signin_bubble_view_browsertest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/browser_window_cocoa.mm
diff --git a/chrome/browser/ui/cocoa/browser_window_cocoa.mm b/chrome/browser/ui/cocoa/browser_window_cocoa.mm
index cb93277aedb03838714273b8af465c77cf5a2f1c..ccb0abbe93f3a621b9e6970fe90fb90c7db48f9c 100644
--- a/chrome/browser/ui/cocoa/browser_window_cocoa.mm
+++ b/chrome/browser/ui/cocoa/browser_window_cocoa.mm
@@ -484,6 +484,7 @@ void BrowserWindowCocoa::ShowChromeToMobileBubble() {
void BrowserWindowCocoa::ShowOneClickSigninBubble(
OneClickSigninBubbleType type,
const string16& email,
+ const string16& error_message,
const StartSyncCallback& start_sync_callback) {
if (type == ONE_CLICK_SIGNIN_BUBBLE_TYPE_BUBBLE) {
scoped_nsobject<OneClickSigninBubbleController> bubble_controller(
« no previous file with comments | « chrome/browser/ui/cocoa/browser_window_cocoa.h ('k') | chrome/browser/ui/gtk/browser_window_gtk.h » ('j') | chrome/browser/ui/views/sync/one_click_signin_bubble_view_browsertest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698