Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 13977021: Enable concatenated impulse responses. (Closed)

Created:
7 years, 7 months ago by Raymond Toy (Google)
Modified:
7 years, 7 months ago
Reviewers:
Chris Rogers, scottmg
CC:
chromium-reviews
Visibility:
Public.

Description

Enable concatenated impulse responses. BUG=227141 This is a follow up of https://codereview.chromium.org/14297003 and https://codereview.chromium.org/14304002. After both CLs have landed, this CL will actually enable support for the concatenated impulse responses and makes it the default. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=197997

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/common.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Chris Rogers
lgtm - I assume you've tested this on other platforms than just Android? you'll need ...
7 years, 7 months ago (2013-05-02 18:33:20 UTC) #1
Raymond Toy (Google)
I tested on linux and mac. The concatenated response is used and sounds the same ...
7 years, 7 months ago (2013-05-02 18:36:08 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years, 7 months ago (2013-05-02 18:47:09 UTC) #3
scottmg
lgtm
7 years, 7 months ago (2013-05-02 19:39:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtoy@google.com/13977021/1
7 years, 7 months ago (2013-05-02 19:51:05 UTC) #5
commit-bot: I haz the power
7 years, 7 months ago (2013-05-02 22:37:28 UTC) #6
Message was sent while issue was closed.
Change committed as 197997

Powered by Google App Engine
This is Rietveld 408576698