Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(767)

Issue 13977004: [Android] Add a dummy uiautomator tests target for chromium testshell. (Closed)

Created:
7 years, 8 months ago by frankf
Modified:
7 years, 8 months ago
Reviewers:
cjhopman, nilesh
CC:
chromium-reviews
Visibility:
Public.

Description

[Android] Add a dummy uiautomator tests target for chromium testshell. BUG=226509 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195592

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added prebuilt jar target to android_tools.gyp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -0 lines) Patch
M build/all_android.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/android/uiautomator_tests/src/org/chromium/chrome/testshell/uiautomator/DummyTest.java View 1 chunk +18 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
frankf
7 years, 8 months ago (2013-04-16 23:53:58 UTC) #1
cjhopman
https://codereview.chromium.org/13977004/diff/1/chrome/chrome_tests.gypi File chrome/chrome_tests.gypi (right): https://codereview.chromium.org/13977004/diff/1/chrome/chrome_tests.gypi#newcode3233 chrome/chrome_tests.gypi:3233: 'input_jars_paths': [ '<(android_sdk)/uiautomator.jar' ], Targets shouldn't add jars directly ...
7 years, 8 months ago (2013-04-17 20:28:35 UTC) #2
frankf
PTAL https://codereview.chromium.org/13977004/diff/1/chrome/chrome_tests.gypi File chrome/chrome_tests.gypi (right): https://codereview.chromium.org/13977004/diff/1/chrome/chrome_tests.gypi#newcode3233 chrome/chrome_tests.gypi:3233: 'input_jars_paths': [ '<(android_sdk)/uiautomator.jar' ], Done. On 2013/04/17 20:28:35, ...
7 years, 8 months ago (2013-04-19 18:06:37 UTC) #3
frankf
+nilesh for OWNERS
7 years, 8 months ago (2013-04-19 18:38:02 UTC) #4
nilesh
LGTM for chrome/android/
7 years, 8 months ago (2013-04-19 19:00:42 UTC) #5
frankf
chris, can you take another look?
7 years, 8 months ago (2013-04-22 17:47:59 UTC) #6
cjhopman
lgtm
7 years, 8 months ago (2013-04-22 17:52:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/frankf@chromium.org/13977004/8001
7 years, 8 months ago (2013-04-22 17:54:31 UTC) #8
commit-bot: I haz the power
7 years, 8 months ago (2013-04-22 21:07:29 UTC) #9
Message was sent while issue was closed.
Change committed as 195592

Powered by Google App Engine
This is Rietveld 408576698