Issue 13976015: Handle retry-after-gc failures within LoadIC::Load and StoreIC::Store.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13976015: Handle retry-after-gc failures within LoadIC::Load and StoreIC::Store. (Closed)

Created:
7 years, 8 months ago by ulan

Modified:
7 years, 8 months ago

Reviewers:
Toon Verwaest

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Handle retry-after-gc failures within LoadIC::Load and StoreIC::Store. Follow-up for r14321, makes the remaining unsafe calls to runtime functions during ic computation safe. R=verwaest@chromium.org BUG=222301 Committed: https://code.google.com/p/v8/source/detail?r=14347

Patch Set 1 #

Total comments: 1

Patch Set 2 : Address comment #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+78 lines, -9 lines)			Patch
M	src/accessors.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/accessors.cc	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	src/ic.cc	View	1	8 chunks	+13 lines, -9 lines	0 comments	Download
M	src/objects.h	View	1	2 chunks	+16 lines, -0 lines	0 comments	Download
M	src/objects.cc	View	1	2 chunks	+27 lines, -0 lines	0 comments	Download
M	src/runtime.h	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/runtime.cc	View	1	1 chunk	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Toon Verwaest

lgtm with nit https://chromiumcodereview.appspot.com/13976015/diff/1/src/objects.h File src/objects.h (right): https://chromiumcodereview.appspot.com/13976015/diff/1/src/objects.h#newcode1111 src/objects.h:1111: remove space again

7 years, 8 months ago (2013-04-18 18:14:11 UTC) #2

ulan

7 years, 8 months ago (2013-04-19 08:30:59 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r14347 (presubmit successful).

Expand Messages | Collapse Messages