Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Side by Side Diff: components/autofill/browser/name_field_unittest.cc

Issue 13973004: Convert string16 -> base::string16 in components/ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/memory/scoped_ptr.h" 5 #include "base/memory/scoped_ptr.h"
6 #include "base/memory/scoped_vector.h" 6 #include "base/memory/scoped_vector.h"
7 #include "base/utf_string_conversions.h" 7 #include "base/utf_string_conversions.h"
8 #include "components/autofill/browser/autofill_field.h" 8 #include "components/autofill/browser/autofill_field.h"
9 #include "components/autofill/browser/autofill_scanner.h" 9 #include "components/autofill/browser/autofill_scanner.h"
10 #include "components/autofill/browser/name_field.h" 10 #include "components/autofill/browser/name_field.h"
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
57 EXPECT_EQ(NAME_MIDDLE, field_type_map_[ASCIIToUTF16("name2")]); 57 EXPECT_EQ(NAME_MIDDLE, field_type_map_[ASCIIToUTF16("name2")]);
58 ASSERT_TRUE( 58 ASSERT_TRUE(
59 field_type_map_.find(ASCIIToUTF16("name3")) != field_type_map_.end()); 59 field_type_map_.find(ASCIIToUTF16("name3")) != field_type_map_.end());
60 EXPECT_EQ(NAME_LAST, field_type_map_[ASCIIToUTF16("name3")]); 60 EXPECT_EQ(NAME_LAST, field_type_map_[ASCIIToUTF16("name3")]);
61 } 61 }
62 62
63 TEST_F(NameFieldTest, FirstMiddleLast2) { 63 TEST_F(NameFieldTest, FirstMiddleLast2) {
64 FormFieldData field; 64 FormFieldData field;
65 field.form_control_type = "text"; 65 field.form_control_type = "text";
66 66
67 field.label = string16(); 67 field.label = base::string16();
68 field.name = ASCIIToUTF16("firstName"); 68 field.name = ASCIIToUTF16("firstName");
69 list_.push_back(new AutofillField(field, ASCIIToUTF16("name1"))); 69 list_.push_back(new AutofillField(field, ASCIIToUTF16("name1")));
70 70
71 field.label = string16(); 71 field.label = base::string16();
72 field.name = ASCIIToUTF16("middleName"); 72 field.name = ASCIIToUTF16("middleName");
73 list_.push_back(new AutofillField(field, ASCIIToUTF16("name2"))); 73 list_.push_back(new AutofillField(field, ASCIIToUTF16("name2")));
74 74
75 field.label = string16(); 75 field.label = base::string16();
76 field.name = ASCIIToUTF16("lastName"); 76 field.name = ASCIIToUTF16("lastName");
77 list_.push_back(new AutofillField(field, ASCIIToUTF16("name3"))); 77 list_.push_back(new AutofillField(field, ASCIIToUTF16("name3")));
78 78
79 AutofillScanner scanner(list_.get()); 79 AutofillScanner scanner(list_.get());
80 field_.reset(Parse(&scanner)); 80 field_.reset(Parse(&scanner));
81 ASSERT_NE(static_cast<NameField*>(NULL), field_.get()); 81 ASSERT_NE(static_cast<NameField*>(NULL), field_.get());
82 ASSERT_TRUE(field_->ClassifyField(&field_type_map_)); 82 ASSERT_TRUE(field_->ClassifyField(&field_type_map_));
83 ASSERT_TRUE( 83 ASSERT_TRUE(
84 field_type_map_.find(ASCIIToUTF16("name1")) != field_type_map_.end()); 84 field_type_map_.find(ASCIIToUTF16("name1")) != field_type_map_.end());
85 EXPECT_EQ(NAME_FIRST, field_type_map_[ASCIIToUTF16("name1")]); 85 EXPECT_EQ(NAME_FIRST, field_type_map_[ASCIIToUTF16("name1")]);
86 ASSERT_TRUE( 86 ASSERT_TRUE(
87 field_type_map_.find(ASCIIToUTF16("name2")) != field_type_map_.end()); 87 field_type_map_.find(ASCIIToUTF16("name2")) != field_type_map_.end());
88 EXPECT_EQ(NAME_MIDDLE, field_type_map_[ASCIIToUTF16("name2")]); 88 EXPECT_EQ(NAME_MIDDLE, field_type_map_[ASCIIToUTF16("name2")]);
89 ASSERT_TRUE( 89 ASSERT_TRUE(
90 field_type_map_.find(ASCIIToUTF16("name3")) != field_type_map_.end()); 90 field_type_map_.find(ASCIIToUTF16("name3")) != field_type_map_.end());
91 EXPECT_EQ(NAME_LAST, field_type_map_[ASCIIToUTF16("name3")]); 91 EXPECT_EQ(NAME_LAST, field_type_map_[ASCIIToUTF16("name3")]);
92 } 92 }
93 93
94 TEST_F(NameFieldTest, FirstLast) { 94 TEST_F(NameFieldTest, FirstLast) {
95 FormFieldData field; 95 FormFieldData field;
96 field.form_control_type = "text"; 96 field.form_control_type = "text";
97 97
98 field.label = string16(); 98 field.label = base::string16();
99 field.name = ASCIIToUTF16("first_name"); 99 field.name = ASCIIToUTF16("first_name");
100 list_.push_back(new AutofillField(field, ASCIIToUTF16("name1"))); 100 list_.push_back(new AutofillField(field, ASCIIToUTF16("name1")));
101 101
102 field.label = string16(); 102 field.label = base::string16();
103 field.name = ASCIIToUTF16("last_name"); 103 field.name = ASCIIToUTF16("last_name");
104 list_.push_back(new AutofillField(field, ASCIIToUTF16("name2"))); 104 list_.push_back(new AutofillField(field, ASCIIToUTF16("name2")));
105 105
106 AutofillScanner scanner(list_.get()); 106 AutofillScanner scanner(list_.get());
107 field_.reset(Parse(&scanner)); 107 field_.reset(Parse(&scanner));
108 ASSERT_NE(static_cast<NameField*>(NULL), field_.get()); 108 ASSERT_NE(static_cast<NameField*>(NULL), field_.get());
109 ASSERT_TRUE(field_->ClassifyField(&field_type_map_)); 109 ASSERT_TRUE(field_->ClassifyField(&field_type_map_));
110 ASSERT_TRUE( 110 ASSERT_TRUE(
111 field_type_map_.find(ASCIIToUTF16("name1")) != field_type_map_.end()); 111 field_type_map_.find(ASCIIToUTF16("name1")) != field_type_map_.end());
112 EXPECT_EQ(NAME_FIRST, field_type_map_[ASCIIToUTF16("name1")]); 112 EXPECT_EQ(NAME_FIRST, field_type_map_[ASCIIToUTF16("name1")]);
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
171 } 171 }
172 172
173 TEST_F(NameFieldTest, FirstLastEmpty) { 173 TEST_F(NameFieldTest, FirstLastEmpty) {
174 FormFieldData field; 174 FormFieldData field;
175 field.form_control_type = "text"; 175 field.form_control_type = "text";
176 176
177 field.label = ASCIIToUTF16("Name"); 177 field.label = ASCIIToUTF16("Name");
178 field.name = ASCIIToUTF16("first_name"); 178 field.name = ASCIIToUTF16("first_name");
179 list_.push_back(new AutofillField(field, ASCIIToUTF16("name1"))); 179 list_.push_back(new AutofillField(field, ASCIIToUTF16("name1")));
180 180
181 field.label = string16(); 181 field.label = base::string16();
182 field.name = ASCIIToUTF16("last_name"); 182 field.name = ASCIIToUTF16("last_name");
183 list_.push_back(new AutofillField(field, ASCIIToUTF16("name2"))); 183 list_.push_back(new AutofillField(field, ASCIIToUTF16("name2")));
184 184
185 AutofillScanner scanner(list_.get()); 185 AutofillScanner scanner(list_.get());
186 field_.reset(Parse(&scanner)); 186 field_.reset(Parse(&scanner));
187 ASSERT_NE(static_cast<NameField*>(NULL), field_.get()); 187 ASSERT_NE(static_cast<NameField*>(NULL), field_.get());
188 ASSERT_TRUE(field_->ClassifyField(&field_type_map_)); 188 ASSERT_TRUE(field_->ClassifyField(&field_type_map_));
189 ASSERT_TRUE( 189 ASSERT_TRUE(
190 field_type_map_.find(ASCIIToUTF16("name1")) != field_type_map_.end()); 190 field_type_map_.find(ASCIIToUTF16("name1")) != field_type_map_.end());
191 EXPECT_EQ(NAME_FIRST, field_type_map_[ASCIIToUTF16("name1")]); 191 EXPECT_EQ(NAME_FIRST, field_type_map_[ASCIIToUTF16("name1")]);
192 ASSERT_TRUE( 192 ASSERT_TRUE(
193 field_type_map_.find(ASCIIToUTF16("name2")) != field_type_map_.end()); 193 field_type_map_.find(ASCIIToUTF16("name2")) != field_type_map_.end());
194 EXPECT_EQ(NAME_LAST, field_type_map_[ASCIIToUTF16("name2")]); 194 EXPECT_EQ(NAME_LAST, field_type_map_[ASCIIToUTF16("name2")]);
195 } 195 }
196 196
197 TEST_F(NameFieldTest, FirstMiddleLastEmpty) { 197 TEST_F(NameFieldTest, FirstMiddleLastEmpty) {
198 FormFieldData field; 198 FormFieldData field;
199 field.form_control_type = "text"; 199 field.form_control_type = "text";
200 200
201 field.label = ASCIIToUTF16("Name"); 201 field.label = ASCIIToUTF16("Name");
202 field.name = ASCIIToUTF16("first_name"); 202 field.name = ASCIIToUTF16("first_name");
203 list_.push_back(new AutofillField(field, ASCIIToUTF16("name1"))); 203 list_.push_back(new AutofillField(field, ASCIIToUTF16("name1")));
204 204
205 field.label = string16(); 205 field.label = base::string16();
206 field.name = ASCIIToUTF16("middle_name"); 206 field.name = ASCIIToUTF16("middle_name");
207 list_.push_back(new AutofillField(field, ASCIIToUTF16("name2"))); 207 list_.push_back(new AutofillField(field, ASCIIToUTF16("name2")));
208 208
209 field.label = string16(); 209 field.label = base::string16();
210 field.name = ASCIIToUTF16("last_name"); 210 field.name = ASCIIToUTF16("last_name");
211 list_.push_back(new AutofillField(field, ASCIIToUTF16("name3"))); 211 list_.push_back(new AutofillField(field, ASCIIToUTF16("name3")));
212 212
213 AutofillScanner scanner(list_.get()); 213 AutofillScanner scanner(list_.get());
214 field_.reset(Parse(&scanner)); 214 field_.reset(Parse(&scanner));
215 ASSERT_NE(static_cast<NameField*>(NULL), field_.get()); 215 ASSERT_NE(static_cast<NameField*>(NULL), field_.get());
216 ASSERT_TRUE(field_->ClassifyField(&field_type_map_)); 216 ASSERT_TRUE(field_->ClassifyField(&field_type_map_));
217 ASSERT_TRUE( 217 ASSERT_TRUE(
218 field_type_map_.find(ASCIIToUTF16("name1")) != field_type_map_.end()); 218 field_type_map_.find(ASCIIToUTF16("name1")) != field_type_map_.end());
219 EXPECT_EQ(NAME_FIRST, field_type_map_[ASCIIToUTF16("name1")]); 219 EXPECT_EQ(NAME_FIRST, field_type_map_[ASCIIToUTF16("name1")]);
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
272 field_.reset(Parse(&scanner)); 272 field_.reset(Parse(&scanner));
273 ASSERT_EQ(static_cast<NameField*>(NULL), field_.get()); 273 ASSERT_EQ(static_cast<NameField*>(NULL), field_.get());
274 } 274 }
275 275
276 // This case is from the dell.com checkout page. The middle initial "mi" string 276 // This case is from the dell.com checkout page. The middle initial "mi" string
277 // came at the end following other descriptive text. http://crbug.com/45123. 277 // came at the end following other descriptive text. http://crbug.com/45123.
278 TEST_F(NameFieldTest, MiddleInitialAtEnd) { 278 TEST_F(NameFieldTest, MiddleInitialAtEnd) {
279 FormFieldData field; 279 FormFieldData field;
280 field.form_control_type = "text"; 280 field.form_control_type = "text";
281 281
282 field.label = string16(); 282 field.label = base::string16();
283 field.name = ASCIIToUTF16("XXXnameXXXfirst"); 283 field.name = ASCIIToUTF16("XXXnameXXXfirst");
284 list_.push_back(new AutofillField(field, ASCIIToUTF16("name1"))); 284 list_.push_back(new AutofillField(field, ASCIIToUTF16("name1")));
285 285
286 field.label = string16(); 286 field.label = base::string16();
287 field.name = ASCIIToUTF16("XXXnameXXXmi"); 287 field.name = ASCIIToUTF16("XXXnameXXXmi");
288 list_.push_back(new AutofillField(field, ASCIIToUTF16("name2"))); 288 list_.push_back(new AutofillField(field, ASCIIToUTF16("name2")));
289 289
290 field.label = string16(); 290 field.label = base::string16();
291 field.name = ASCIIToUTF16("XXXnameXXXlast"); 291 field.name = ASCIIToUTF16("XXXnameXXXlast");
292 list_.push_back(new AutofillField(field, ASCIIToUTF16("name3"))); 292 list_.push_back(new AutofillField(field, ASCIIToUTF16("name3")));
293 293
294 AutofillScanner scanner(list_.get()); 294 AutofillScanner scanner(list_.get());
295 field_.reset(Parse(&scanner)); 295 field_.reset(Parse(&scanner));
296 ASSERT_NE(static_cast<NameField*>(NULL), field_.get()); 296 ASSERT_NE(static_cast<NameField*>(NULL), field_.get());
297 ASSERT_TRUE(field_->ClassifyField(&field_type_map_)); 297 ASSERT_TRUE(field_->ClassifyField(&field_type_map_));
298 ASSERT_TRUE( 298 ASSERT_TRUE(
299 field_type_map_.find(ASCIIToUTF16("name1")) != field_type_map_.end()); 299 field_type_map_.find(ASCIIToUTF16("name1")) != field_type_map_.end());
300 EXPECT_EQ(NAME_FIRST, field_type_map_[ASCIIToUTF16("name1")]); 300 EXPECT_EQ(NAME_FIRST, field_type_map_[ASCIIToUTF16("name1")]);
301 ASSERT_TRUE( 301 ASSERT_TRUE(
302 field_type_map_.find(ASCIIToUTF16("name2")) != field_type_map_.end()); 302 field_type_map_.find(ASCIIToUTF16("name2")) != field_type_map_.end());
303 EXPECT_EQ(NAME_MIDDLE_INITIAL, field_type_map_[ASCIIToUTF16("name2")]); 303 EXPECT_EQ(NAME_MIDDLE_INITIAL, field_type_map_[ASCIIToUTF16("name2")]);
304 ASSERT_TRUE( 304 ASSERT_TRUE(
305 field_type_map_.find(ASCIIToUTF16("name3")) != field_type_map_.end()); 305 field_type_map_.find(ASCIIToUTF16("name3")) != field_type_map_.end());
306 EXPECT_EQ(NAME_LAST, field_type_map_[ASCIIToUTF16("name3")]); 306 EXPECT_EQ(NAME_LAST, field_type_map_[ASCIIToUTF16("name3")]);
307 } 307 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698