Issue 13972015: Select last word when double clicked after the last character

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13972015: Select last word when double clicked after the last character (Closed)

Created:
7 years, 8 months ago by ckocagil

Modified:
7 years, 8 months ago

Reviewers:
msw

CC:
chromium-reviews

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Select last word when double clicked after the last character When RenderText::SelectWord is called while the cursor is on a boundary, the word to the right is selected. This patch specially handles the case where the cursor is at the rightmost position to select the word to the left. BUG=232023 TEST=See repro steps at http://crbug.com/232023 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194901

Patch Set 1 #

Patch Set 2 : 2 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -0 lines)			Patch
	M	ui/gfx/render_text.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download
	M	ui/gfx/render_text_unittest.cc	View	1	1 chunk	+20 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

msw

LGTM thanks! But would you mind adding a unit test? (I'll take another look if ...

7 years, 8 months ago (2013-04-16 23:22:26 UTC) #2

ckocagil

On 2013/04/16 23:22:26, msw wrote: > LGTM thanks! But would you mind adding a unit ...

7 years, 8 months ago (2013-04-16 23:58:34 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ckocagil@chromium.org/13972015/3001

7 years, 8 months ago (2013-04-18 10:41:36 UTC) #5

Message was sent while issue was closed.

Change committed as 194901

Expand Messages | Collapse Messages