Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1227)

Unified Diff: presubmit_support.py

Issue 13966016: Allow presubmit_support to fetch issue data from Rietveld. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: presubmit_support.py
diff --git a/presubmit_support.py b/presubmit_support.py
index e88fbcf08dfff8bccb899b284bde943303155f59..a1a1701af9db7bfe86c1b45674902e652a691fda 100755
--- a/presubmit_support.py
+++ b/presubmit_support.py
@@ -1332,6 +1332,8 @@ def Main(argv):
parser.add_option("--rietveld_url", help=optparse.SUPPRESS_HELP)
parser.add_option("--rietveld_email", help=optparse.SUPPRESS_HELP)
parser.add_option("--rietveld_password", help=optparse.SUPPRESS_HELP)
+ parser.add_option("--rietveld_fetch", action='store_true', default=False,
+ help=optparse.SUPPRESS_HELP)
options, args = parser.parse_args(argv)
if options.verbose >= 2:
logging.basicConfig(level=logging.DEBUG)
@@ -1349,6 +1351,13 @@ def Main(argv):
options.rietveld_url,
options.rietveld_email,
options.rietveld_password)
+ if options.rietveld_fetch:
+ assert options.issue
+ props = rietveld_obj.get_issue_properties(options.issue, False)
+ options.author = props['owner_email']
+ options.description = props['description']
+ logging.info('Got author: "%s"', options.author)
+ logging.info('Got description: """\n%s\n"""', options.description)
try:
with canned_check_filter(options.skip_canned):
results = DoPresubmitChecks(
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698