Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 13962003: [Android] Use the build-generated list of libraries for gtest APKs (Closed)

Created:
7 years, 8 months ago by cjhopman
Modified:
7 years, 8 months ago
Reviewers:
Yaron
CC:
chromium-reviews, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, yfriedman+watch_chromium.org, bulach+watch_chromium.org, klundberg+watch_chromium.org, ilevy+watch_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

[Android] Use the build-generated list of libraries for gtest APKs For normal APKs, the build generates a list of libraries to load at build time and this is used at runtime to load libraries. Update our gtest APKs to use this. This makes gtest APKs work in the component build. BUG=158821 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193536

Patch Set 1 #

Patch Set 2 : Remove no longer supported test target #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -69 lines) Patch
M build/all_android.gyp View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M build/apk_test.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M build/common.gypi View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M content/public/android/java/templates/NativeLibraries.template View 1 chunk +3 lines, -1 line 0 comments Download
M testing/android/java/src/org/chromium/native_test/ChromeNativeTestActivity.java View 3 chunks +10 lines, -16 lines 0 comments Download
M testing/android/native_test.gyp View 1 1 chunk +0 lines, -44 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
cjhopman
7 years, 8 months ago (2013-04-10 01:11:14 UTC) #1
Yaron
lgtm I don't like the layering violations, but this is acceptable temporarily since moving the ...
7 years, 8 months ago (2013-04-10 01:21:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/13962003/1
7 years, 8 months ago (2013-04-10 20:09:19 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-10 20:25:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/13962003/18001
7 years, 8 months ago (2013-04-10 22:33:06 UTC) #5
commit-bot: I haz the power
7 years, 8 months ago (2013-04-11 01:52:48 UTC) #6
Message was sent while issue was closed.
Change committed as 193536

Powered by Google App Engine
This is Rietveld 408576698