Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 13959005: cc: Recycle resources for software video decode. (Closed)

Created:
7 years, 8 months ago by danakj
Modified:
7 years, 8 months ago
Reviewers:
enne (OOO), piman
CC:
chromium-reviews, feature-media-reviews_chromium.org, cc-bugs_chromium.org, backer, slavi, sheu
Visibility:
Public.

Description

cc: Recycle resources for software video decode. When we update a compositor resource from a media::VideoFrame, try to reuse resources from previous frames that were returned to us by the ResourceProvider. R=piman,enne BUG=179729 Depends on: https://codereview.chromium.org/13445009/ Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193409

Patch Set 1 #

Total comments: 2

Patch Set 2 : TODO #

Patch Set 3 : Destroy recycled textures when VRU shuts down #

Unified diffs Side-by-side diffs Delta from patch set Stats (+142 lines, -46 lines) Patch
M cc/layers/video_layer_impl.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M cc/resources/video_resource_updater.h View 4 chunks +29 lines, -1 line 0 comments Download
M cc/resources/video_resource_updater.cc View 1 2 7 chunks +110 lines, -45 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
danakj
7 years, 8 months ago (2013-04-09 23:52:36 UTC) #1
piman
LGTM I guess, but I'll mention the thing I think is weird - that I ...
7 years, 8 months ago (2013-04-10 00:56:30 UTC) #2
danakj
https://codereview.chromium.org/13959005/diff/1/cc/resources/video_resource_updater.cc File cc/resources/video_resource_updater.cc (right): https://codereview.chromium.org/13959005/diff/1/cc/resources/video_resource_updater.cc#newcode359 cc/resources/video_resource_updater.cc:359: GLC(context, context->consumeTextureCHROMIUM(GL_TEXTURE_2D, mailbox.name)); On 2013/04/10 00:56:30, piman wrote: > ...
7 years, 8 months ago (2013-04-10 01:15:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/13959005/6001
7 years, 8 months ago (2013-04-10 04:57:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/13959005/27001
7 years, 8 months ago (2013-04-10 15:43:05 UTC) #5
commit-bot: I haz the power
7 years, 8 months ago (2013-04-10 17:32:23 UTC) #6
Message was sent while issue was closed.
Change committed as 193409

Powered by Google App Engine
This is Rietveld 408576698