Issue 13956018: Android: Make number of test retries configurable.

Issue 13956018: Android: Make number of test retries configurable. (Closed)

Created:
7 years, 8 months ago by nilesh

Modified:
7 years, 8 months ago

Reviewers:
craigdh, frankf

CC:
chromium-reviews, klundberg+watch_chromium.org, frankf+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Android: Make number of test retries configurable. BUG=230113 This also reduces the default number of retries from 3 to 2. So we will now run a test 3 times before giving up (instead of 4). Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194078

Patch Set 1 #

Patch Set 2 : fix typo #

Total comments: 4

Patch Set 3 : #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -14 lines)			Patch
M	build/android/pylib/base/shard.py	View	1 2	8 chunks	+14 lines, -8 lines	0 comments	Download
M	build/android/pylib/browsertests/dispatch.py	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download
M	build/android/pylib/gtest/dispatch.py	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download
M	build/android/pylib/instrumentation/dispatch.py	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download
M	build/android/pylib/utils/test_options_parser.py	View	1 2	2 chunks	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

frankf

https://codereview.chromium.org/13956018/diff/2001/build/android/pylib/browsertests/dispatch.py File build/android/pylib/browsertests/dispatch.py (right): https://codereview.chromium.org/13956018/diff/2001/build/android/pylib/browsertests/dispatch.py#newcode72 build/android/pylib/browsertests/dispatch.py:72: num_retries=options.repeat) Description for options.repeat should be updated. We're repeating ...

7 years, 8 months ago (2013-04-12 21:19:38 UTC) #2

craigdh

https://codereview.chromium.org/13956018/diff/2001/build/android/pylib/base/shard.py File build/android/pylib/base/shard.py (right): https://codereview.chromium.org/13956018/diff/2001/build/android/pylib/base/shard.py#newcode266 build/android/pylib/base/shard.py:266: num_retries=2): add documentation for the new arg

7 years, 8 months ago (2013-04-12 21:20:34 UTC) #3

nilesh

7 years, 8 months ago (2013-04-12 21:42:55 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nileshagrawal@chromium.org/13956018/8001

7 years, 8 months ago (2013-04-12 22:46:35 UTC) #6

Message was sent while issue was closed.

Change committed as 194078

Expand Messages | Collapse Messages