Remove insertRange.

Remove insertRange.

Committed: https://code.google.com/p/dart/source/detail?r=21464

[nweiz, 2013-04-12 21:49:01]

This is a nice change. LGTM other than a couple comments.

https://codereview.chromium.org/13956006/diff/1039/pkg/pathos/lib/path.dart
File pkg/pathos/lib/path.dart (right):

https://codereview.chromium.org/13956006/diff/1039/pkg/pathos/lib/path.dart#n...
pkg/pathos/lib/path.dart:21: for (int i = 0; i < length; i++) {
"var i"

We generally don't use explicit type declarations within method bodies.

https://codereview.chromium.org/13956006/diff/1039/pkg/pathos/lib/path.dart#n...
pkg/pathos/lib/path.dart:23: }
Won't

   for (var i = 0; i < length; i++) {
     list.insert(0, fillValue);
   }

do the same thing just as efficiently? I'd find that more readable.

[floitsch, 2013-04-12 22:14:06]

https://codereview.chromium.org/13956006/diff/1039/pkg/pathos/lib/path.dart
File pkg/pathos/lib/path.dart (right):

https://codereview.chromium.org/13956006/diff/1039/pkg/pathos/lib/path.dart#n...
pkg/pathos/lib/path.dart:21: for (int i = 0; i < length; i++) {
On 2013/04/12 21:49:01, nweiz wrote:
> "var i"
> 
> We generally don't use explicit type declarations within method bodies.

Done.

https://codereview.chromium.org/13956006/diff/1039/pkg/pathos/lib/path.dart#n...
pkg/pathos/lib/path.dart:23: }
On 2013/04/12 21:49:01, nweiz wrote:
> Won't
> 
>    for (var i = 0; i < length; i++) {
>      list.insert(0, fillValue);
>    }
> 
> do the same thing just as efficiently? I'd find that more readable.

That would be O(n^2). So no. it wouldn't be as efficient.

[nweiz, 2013-04-12 22:25:52]

https://codereview.chromium.org/13956006/diff/1039/pkg/pathos/lib/path.dart
File pkg/pathos/lib/path.dart (right):

https://codereview.chromium.org/13956006/diff/1039/pkg/pathos/lib/path.dart#n...
pkg/pathos/lib/path.dart:23: }
On 2013/04/12 22:14:06, floitsch wrote:
> On 2013/04/12 21:49:01, nweiz wrote:
> > Won't
> > 
> >    for (var i = 0; i < length; i++) {
> >      list.insert(0, fillValue);
> >    }
> > 
> > do the same thing just as efficiently? I'd find that more readable.
> 
> That would be O(n^2). So no. it wouldn't be as efficient.

I guess I was assuming List was smarter than it actually is. Maybe we should be
using a Queue for path.parts, but that's out of scope for this change.

[blois, 2013-04-12 23:01:37]

DOM changes lgtm

[Lasse Reichstein Nielsen, 2013-04-15 11:19:15]

lgtm

https://chromiumcodereview.appspot.com/13956006/diff/8001/sdk/lib/_internal/d...
File
sdk/lib/_internal/dartdoc/test/test_files/packages/fake_package/fake_package.dart
(left):

https://chromiumcodereview.appspot.com/13956006/diff/8001/sdk/lib/_internal/d...
sdk/lib/_internal/dartdoc/test/test_files/packages/fake_package/fake_package.dart:4:
}
Was this related to insertRange?

https://chromiumcodereview.appspot.com/13956006/diff/8001/tests/co19/co19-run...
File tests/co19/co19-runtime.status (right):

https://chromiumcodereview.appspot.com/13956006/diff/8001/tests/co19/co19-run...
tests/co19/co19-runtime.status:448: LibTest/core/List/every_A01_t01: Fail #
insertRange is removed. Issue TODO
Remember to add issue to all status files.

[floitsch, 2013-04-15 14:22:30]

https://codereview.chromium.org/13956006/diff/8001/sdk/lib/_internal/dartdoc/...
File
sdk/lib/_internal/dartdoc/test/test_files/packages/fake_package/fake_package.dart
(left):

https://codereview.chromium.org/13956006/diff/8001/sdk/lib/_internal/dartdoc/...
sdk/lib/_internal/dartdoc/test/test_files/packages/fake_package/fake_package.dart:4:
}
On 2013/04/15 11:19:15, Lasse Reichstein Nielsen wrote:
> Was this related to insertRange?

No. this file keeps appearing and disappearing in my checkout.

https://codereview.chromium.org/13956006/diff/8001/tests/co19/co19-runtime.st...
File tests/co19/co19-runtime.status (right):

https://codereview.chromium.org/13956006/diff/8001/tests/co19/co19-runtime.st...
tests/co19/co19-runtime.status:448: LibTest/core/List/every_A01_t01: Fail #
insertRange is removed. Issue TODO
On 2013/04/15 11:19:15, Lasse Reichstein Nielsen wrote:
> Remember to add issue to all status files.

Done.

[floitsch, 2013-04-15 15:20:59]

Committed patchset #4 manually as r21464 (presubmit successful).