Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 13956003: Tab capture: do 200 rendundant captures of static content. (Closed)

Created:
7 years, 8 months ago by ncarter (slow)
Modified:
7 years, 8 months ago
Reviewers:
hclam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Tab capture: do 200 rendundant captures of static content. Redundantly capturing the same frame allows iterative quality enhancement, and also allows the buffer to fill in "buffered mode". TEST=text should become clearer after pausing animation at low bit rate. BUG=223977, 225669 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193346

Patch Set 1 #

Patch Set 2 : Self-review fixes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -35 lines) Patch
M content/browser/renderer_host/media/web_contents_video_capture_device.h View 1 2 chunks +4 lines, -1 line 0 comments Download
M content/browser/renderer_host/media/web_contents_video_capture_device.cc View 1 4 chunks +27 lines, -7 lines 0 comments Download
M content/browser/renderer_host/media/web_contents_video_capture_device_unittest.cc View 6 chunks +37 lines, -27 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ncarter (slow)
Please review.
7 years, 8 months ago (2013-04-10 01:51:27 UTC) #1
Alpha Left Google
LGTM. I think the right approach is to specify the value of googStaticRefresh in video ...
7 years, 8 months ago (2013-04-10 02:59:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nick@chromium.org/13956003/2001
7 years, 8 months ago (2013-04-10 05:28:03 UTC) #3
commit-bot: I haz the power
7 years, 8 months ago (2013-04-10 08:36:55 UTC) #4
Message was sent while issue was closed.
Change committed as 193346

Powered by Google App Engine
This is Rietveld 408576698