Issue 13954012: Move GetFallbackInputMethodDescriptor function to InputMethodUtil.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13954012: Move GetFallbackInputMethodDescriptor function to InputMethodUtil. (Closed)

Created:
7 years, 8 months ago by Seigo Nonaka

Modified:
7 years, 8 months ago

Reviewers:
satorux1

CC:
chromium-reviews, nkostylev+watch_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, yusukes+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Move GetFallbackInputMethodDescriptor function to InputMethodUtil. I think this function should be in InputMethodUtil rather than in InputMethodDescriptors. Let me clean up InputMethodDescriptor before starting refactoring. BUG=164375 TEST=None, ran unit_tests. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195121

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -40 lines)			Patch
M	chrome/browser/chromeos/input_method/input_method_manager_impl.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/input_method_util.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/input_method_util.cc	View	2 chunks	+10 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/input_method/mock_input_method_manager.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	chromeos/ime/input_method_descriptor.h	View	2 chunks	+0 lines, -8 lines	0 comments	Download
M	chromeos/ime/input_method_descriptor.cc	View	2 chunks	+0 lines, -26 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/13954012/1

7 years, 8 months ago (2013-04-19 04:25:38 UTC) #3

Message was sent while issue was closed.

Change committed as 195121

Expand Messages | Collapse Messages