Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 13947040: Enable net_unittests that rely on device time settings on Android. (Closed)

Created:
7 years, 8 months ago by ppi
Modified:
7 years, 8 months ago
Reviewers:
digit, wtc, pliard
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, klundberg+watch_chromium.org, ilevy+watch_chromium.org, frankf+watch_chromium.org, Ryan Sleevi, wtc
Visibility:
Public.

Description

Enable net_unittests that rely on device time settings on Android. Since http://crbug.com/164180 is now fixed, we can enable ~10 unittests that depend on the device time settings and were failing exclusively on bots. BUG=160756 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195225

Patch Set 1 : #

Patch Set 2 : #

Total comments: 5

Patch Set 3 : Address wtc@ remark #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -14 lines) Patch
M build/android/pylib/gtest/filter/net_unittests_disabled View 1 2 2 chunks +2 lines, -14 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
ppi
Could you guys have a quick look? Should be easy to review.
7 years, 8 months ago (2013-04-18 16:02:58 UTC) #1
Philippe
On 2013/04/18 16:02:58, ppi wrote: > Could you guys have a quick look? Should be ...
7 years, 8 months ago (2013-04-18 16:13:37 UTC) #2
ppi
On 2013/04/18 16:13:37, Philippe wrote: > On 2013/04/18 16:02:58, ppi wrote: > > Could you ...
7 years, 8 months ago (2013-04-18 16:14:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ppi@chromium.org/13947040/4002
7 years, 8 months ago (2013-04-18 16:14:47 UTC) #4
digit1
lgtm. that's great :)
7 years, 8 months ago (2013-04-18 16:16:05 UTC) #5
wtc
Patch set 2 LGTM. I have two questions. https://codereview.chromium.org/13947040/diff/4002/build/android/pylib/gtest/filter/net_unittests_disabled File build/android/pylib/gtest/filter/net_unittests_disabled (right): https://codereview.chromium.org/13947040/diff/4002/build/android/pylib/gtest/filter/net_unittests_disabled#newcode4 build/android/pylib/gtest/filter/net_unittests_disabled:4: MultiThreadedCertVerifierTest.CancelRequest ...
7 years, 8 months ago (2013-04-18 17:26:39 UTC) #6
ppi
https://codereview.chromium.org/13947040/diff/4002/build/android/pylib/gtest/filter/net_unittests_disabled File build/android/pylib/gtest/filter/net_unittests_disabled (right): https://codereview.chromium.org/13947040/diff/4002/build/android/pylib/gtest/filter/net_unittests_disabled#newcode4 build/android/pylib/gtest/filter/net_unittests_disabled:4: MultiThreadedCertVerifierTest.CancelRequest On 2013/04/18 17:26:39, wtc wrote: > > Should ...
7 years, 8 months ago (2013-04-18 18:07:58 UTC) #7
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=30151
7 years, 8 months ago (2013-04-18 18:39:28 UTC) #8
ppi
https://codereview.chromium.org/13947040/diff/4002/build/android/pylib/gtest/filter/net_unittests_disabled File build/android/pylib/gtest/filter/net_unittests_disabled (right): https://codereview.chromium.org/13947040/diff/4002/build/android/pylib/gtest/filter/net_unittests_disabled#newcode4 build/android/pylib/gtest/filter/net_unittests_disabled:4: MultiThreadedCertVerifierTest.CancelRequest On 2013/04/18 18:07:58, ppi wrote: > On 2013/04/18 ...
7 years, 8 months ago (2013-04-19 11:59:48 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ppi@chromium.org/13947040/33001
7 years, 8 months ago (2013-04-19 12:00:17 UTC) #10
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) content_browsertests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=30733
7 years, 8 months ago (2013-04-19 13:36:53 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ppi@chromium.org/13947040/33001
7 years, 8 months ago (2013-04-19 17:02:08 UTC) #12
wtc
Patch set 3 LGTM. Thanks!
7 years, 8 months ago (2013-04-19 17:23:19 UTC) #13
commit-bot: I haz the power
7 years, 8 months ago (2013-04-19 17:48:50 UTC) #14
Message was sent while issue was closed.
Change committed as 195225

Powered by Google App Engine
This is Rietveld 408576698