Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 13945007: filemanager: fix a missing param for the introduced DirectoryContentsDriveSearchMetadata. (Closed)

Created:
7 years, 8 months ago by Haruki Sato
Modified:
7 years, 8 months ago
Reviewers:
mtomasz
CC:
chromium-reviews, rginda+watch_chromium.org, arv+watch_chromium.org
Visibility:
Public.

Description

filemanager: fix a missing param for the introduced DirectoryContentsDriveSearchMetadata. BUG=none TEST=unittests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193327

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix another mistake. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/resources/file_manager/js/directory_contents.js View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Haruki Sato
7 years, 8 months ago (2013-04-09 13:10:33 UTC) #1
mtomasz
https://codereview.chromium.org/13945007/diff/1/chrome/browser/resources/file_manager/js/directory_contents.js File chrome/browser/resources/file_manager/js/directory_contents.js (right): https://codereview.chromium.org/13945007/diff/1/chrome/browser/resources/file_manager/js/directory_contents.js#newcode755 chrome/browser/resources/file_manager/js/directory_contents.js:755: this.context_, this.directoryEntry_, this.fakeDirEntry_, this.directoryEntry_ -> this.driveDirEntry_ ?
7 years, 8 months ago (2013-04-09 14:22:52 UTC) #2
Haruki Sato
https://codereview.chromium.org/13945007/diff/1/chrome/browser/resources/file_manager/js/directory_contents.js File chrome/browser/resources/file_manager/js/directory_contents.js (right): https://codereview.chromium.org/13945007/diff/1/chrome/browser/resources/file_manager/js/directory_contents.js#newcode755 chrome/browser/resources/file_manager/js/directory_contents.js:755: this.context_, this.directoryEntry_, this.fakeDirEntry_, On 2013/04/09 14:22:52, mtomasz wrote: > ...
7 years, 8 months ago (2013-04-10 01:36:32 UTC) #3
mtomasz
lgtm
7 years, 8 months ago (2013-04-10 02:03:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haruki@chromium.org/13945007/6001
7 years, 8 months ago (2013-04-10 02:43:03 UTC) #5
commit-bot: I haz the power
7 years, 8 months ago (2013-04-10 04:59:23 UTC) #6
Message was sent while issue was closed.
Change committed as 193327

Powered by Google App Engine
This is Rietveld 408576698