Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 13942011: Fix bugs wrt to immrsive mode being disabled (Closed)

Created:
7 years, 8 months ago by pkotwicz
Modified:
7 years, 8 months ago
Reviewers:
James Cook
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Fix bugs wrt focus and anchored widgets and immersive mode being disabled. See bugs below for more details. BUG=188567, 233483 Test=ImmersiveModeControllerAshTest.* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195364

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -16 lines) Patch
M chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc View 1 2 6 chunks +23 lines, -15 lines 0 comments Download
M chrome/browser/ui/views/frame/immersive_mode_controller_ash_browsertest.cc View 1 2 3 4 chunks +56 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
pkotwicz
- Fixed anchored widgets so that they are not repositioned while immersive mode is disabled. ...
7 years, 8 months ago (2013-04-19 04:31:34 UTC) #1
pkotwicz
James, can you please take a look? Sorry for the delay and that I did ...
7 years, 8 months ago (2013-04-19 04:32:39 UTC) #2
James Cook
LGTM. Thanks for adding tests for these cases - I'm feeling better and better about ...
7 years, 8 months ago (2013-04-19 17:37:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/13942011/5003
7 years, 8 months ago (2013-04-19 17:55:16 UTC) #4
commit-bot: I haz the power
7 years, 8 months ago (2013-04-20 01:50:50 UTC) #5
Message was sent while issue was closed.
Change committed as 195364

Powered by Google App Engine
This is Rietveld 408576698