Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(723)

Issue 13942004: Adding PrintTo of ObjectPath for gtest. (Closed)

Created:
7 years, 8 months ago by pneubeck (no reviews)
Modified:
7 years, 8 months ago
Reviewers:
satorux1
CC:
chromium-reviews
Visibility:
Public.

Description

Adding PrintTo of ObjectPath. PrintTo is used by gtest/gmock for pretty printing. This change makes debugging tests easier. BUG=NONE Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193920

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M dbus/object_path.h View 2 chunks +4 lines, -0 lines 0 comments Download
M dbus/object_path.cc View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
pneubeck (no reviews)
Splitted into separate CL as suggested. I also removed the string constants "ObjectPath(" and ")", ...
7 years, 8 months ago (2013-04-11 08:03:38 UTC) #1
satorux1
Thank you for splitting. I'll be happy to l-g-t-m if the discussion on chromium-dev is ...
7 years, 8 months ago (2013-04-11 08:18:20 UTC) #2
satorux1
LGTM. No one seems to feel strongly about it. :)
7 years, 8 months ago (2013-04-12 06:02:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pneubeck@chromium.org/13942004/1
7 years, 8 months ago (2013-04-12 06:37:54 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=134229
7 years, 8 months ago (2013-04-12 09:20:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pneubeck@chromium.org/13942004/1
7 years, 8 months ago (2013-04-12 09:27:09 UTC) #6
commit-bot: I haz the power
7 years, 8 months ago (2013-04-12 14:16:37 UTC) #7
Message was sent while issue was closed.
Change committed as 193920

Powered by Google App Engine
This is Rietveld 408576698