Issue 13940014: Simplify some code related to x64 calling convention.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13940014: Simplify some code related to x64 calling convention. (Closed)

Created:
7 years, 8 months ago by Yang

Modified:
7 years, 8 months ago

Reviewers:
mvstanton

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Simplify some code related to x64 calling convention. R=mvstanton@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=14409

Patch Set 1 #

Total comments: 2

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+53 lines, -122 lines)			Patch
M	src/x64/assembler-x64.h	View	1 chunk	+13 lines, -0 lines	1 comment	Download
M	src/x64/builtins-x64.cc	View	1 chunk	+1 line, -5 lines	0 comments	Download
M	src/x64/code-stubs-x64.cc	View	8 chunks	+21 lines, -50 lines	1 comment	Download
M	src/x64/deoptimizer-x64.cc	View	3 chunks	+8 lines, -23 lines	0 comments	Download
M	src/x64/full-codegen-x64.cc	View	2 chunks	+5 lines, -16 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View	2 chunks	+2 lines, -12 lines	0 comments	Download
M	src/x64/lithium-x64.cc	View	2 chunks	+2 lines, -11 lines	0 comments	Download
M	src/x64/macro-assembler-x64.cc	View	1 chunk	+1 line, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

mvstanton

Hi Yang, just a couple comment issues. Then lgtm. Thanks! --Michael https://chromiumcodereview.appspot.com/13940014/diff/1/src/x64/assembler-x64.h File src/x64/assembler-x64.h (right): ...

7 years, 8 months ago (2013-04-24 10:54:54 UTC) #2

Yang

7 years, 8 months ago (2013-04-24 12:01:17 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r14409 (presubmit successful).

Expand Messages | Collapse Messages