Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Issue 1393723002: Allow SiteEngagementService::IsEnabled to respect field trial groups. (Closed)

Created:
5 years, 2 months ago by dominickn
Modified:
5 years, 2 months ago
Reviewers:
calamity
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@time-on-site-finch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow SiteEngagementService::IsEnabled to respect field trial groups. This CL allows the site engagement service to be activated when a field trial group name starting with "Enabled" is present. BUG=539723 Committed: https://crrev.com/f823ead71e30e5b79cd0cda41a7d5bb8366973e0 Cr-Commit-Position: refs/heads/master@{#352772}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M chrome/browser/engagement/site_engagement_service.cc View 1 2 chunks +12 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dominickn
PTAL, thanks
5 years, 2 months ago (2015-10-07 04:05:33 UTC) #2
calamity
lgtm
5 years, 2 months ago (2015-10-07 04:27:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1393723002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1393723002/20001
5 years, 2 months ago (2015-10-07 04:33:21 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-07 04:39:13 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-07 04:40:20 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f823ead71e30e5b79cd0cda41a7d5bb8366973e0
Cr-Commit-Position: refs/heads/master@{#352772}

Powered by Google App Engine
This is Rietveld 408576698