Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Issue 13936005: Enable C++11 mode for iOS (Closed)

Created:
7 years, 8 months ago by stuartmorgan
Modified:
7 years, 7 months ago
Reviewers:
Nico, qsr
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Enable C++11 mode for iOS Matches the flags to the OS X clang settings for C++11 to minimize confusion, but it would be straightforward to enable the string literal warning on iOS at this point. Removes a warning suppression that's duplicated by an Xcode setting just above (again, matching OS X) BUG=226494 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=201284

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M build/common.gypi View 1 2 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
stuartmorgan
7 years, 8 months ago (2013-04-10 13:26:08 UTC) #1
qsr
https://codereview.chromium.org/13936005/diff/1/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/13936005/diff/1/build/common.gypi#newcode3817 build/common.gypi:3817: 'CLANG_CXX_LANGUAGE_STANDARD': 'gnu++0x', How do we plan to be notified ...
7 years, 8 months ago (2013-04-10 13:45:33 UTC) #2
stuartmorgan
On 2013/04/10 13:45:33, qsr wrote: > How do we plan to be notified when we ...
7 years, 8 months ago (2013-04-10 14:07:04 UTC) #3
qsr
lgtm
7 years, 8 months ago (2013-04-10 14:08:43 UTC) #4
stuartmorgan
thakis: FYI, finally turning on C++11 for iOS. When you guys change the mode, let ...
7 years, 8 months ago (2013-04-10 14:09:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stuartmorgan@chromium.org/13936005/1
7 years, 8 months ago (2013-04-10 14:10:17 UTC) #6
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-10 14:15:32 UTC) #7
stuartmorgan
Sigh. The SDK should be 6.1, but CQ at least has 6.0, which apparently has ...
7 years, 8 months ago (2013-04-10 14:22:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stuartmorgan@chromium.org/13936005/16001
7 years, 7 months ago (2013-05-21 08:13:12 UTC) #9
commit-bot: I haz the power
7 years, 7 months ago (2013-05-21 11:08:50 UTC) #10
Message was sent while issue was closed.
Change committed as 201284

Powered by Google App Engine
This is Rietveld 408576698