Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(821)

Unified Diff: components/webdata/common/web_database_migration_unittest.cc

Issue 13935005: Remove explicit thread manipulation from WebDB migration test. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/webdata/common/web_database_migration_unittest.cc
diff --git a/components/webdata/common/web_database_migration_unittest.cc b/components/webdata/common/web_database_migration_unittest.cc
index 64268fb5cb22889686f41429966117056ab30945..f9d8b3575b6a64ddc185ee3bfe7366902ffd2077 100644
--- a/components/webdata/common/web_database_migration_unittest.cc
+++ b/components/webdata/common/web_database_migration_unittest.cc
@@ -28,7 +28,6 @@
#include "components/autofill/browser/webdata/autofill_entry.h"
#include "components/autofill/browser/webdata/autofill_table.h"
#include "components/webdata/common/web_database.h"
-#include "content/public/test/test_browser_thread.h"
#include "sql/statement.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -36,7 +35,6 @@ using autofill::AutofillProfile;
using autofill::AutofillTable;
using autofill::CreditCard;
using base::Time;
-using content::BrowserThread;
namespace {
@@ -162,13 +160,7 @@ void CheckNoBackupData(const sql::Connection& connection,
// |WebDatabase::MigrateOldVersionsAsNeeded()|.
class WebDatabaseMigrationTest : public testing::Test {
public:
- // In order to access the application locale -- which the tested functions do
- // internally -- this test must run on the UI thread.
- // TODO(isherman): The WebDatabase code should probably verify that it is
- // running on the DB thread. Once that verification is added, this code will
- // need to be updated to create both threads.
- WebDatabaseMigrationTest()
- : ui_thread_(BrowserThread::UI, &message_loop_for_ui_) {}
+ WebDatabaseMigrationTest() {}
virtual ~WebDatabaseMigrationTest() {}
virtual void SetUp() {
@@ -243,8 +235,6 @@ class WebDatabaseMigrationTest : public testing::Test {
void LoadDatabase(const base::FilePath::StringType& file);
private:
- MessageLoopForUI message_loop_for_ui_;
- content::TestBrowserThread ui_thread_;
base::ScopedTempDir temp_dir_;
DISALLOW_COPY_AND_ASSIGN(WebDatabaseMigrationTest);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698