Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
13934025:
Android: Enable FileUtilProxyTest.Touch and PlatformFile.TouchGetInfoPlatformFile. (Closed)
|
Created:
7 years, 8 months ago by nilesh Modified:
7 years, 7 months ago CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, klundberg+watch_chromium.org, erikwright+watch_chromium.org, ilevy+watch_chromium.org, frankf+watch_chromium.org Base URL:
svn://svn.chromium.org/chrome/trunk/src Visibility:
Public. |
DescriptionAndroid: Enable FileUtilProxyTest.Touch and PlatformFile.TouchGetInfoPlatformFile.
BUG=86494
These are passing.
TBR=jar@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=197099
Patch Set 1 #
Total comments: 5
Messages
Total messages: 17 (0 generated)
Enabling these tests are they are working on Android. The bug never mentions them being flaky on Android.
https://codereview.chromium.org/13934025/diff/1/build/android/pylib/gtest/fil... File build/android/pylib/gtest/filter/base_unittests_disabled (left): https://codereview.chromium.org/13934025/diff/1/build/android/pylib/gtest/fil... build/android/pylib/gtest/filter/base_unittests_disabled:20: FileUtilProxyTest.Touch Doesn't this reenable the test on all platforms?
https://codereview.chromium.org/13934025/diff/1/build/android/pylib/gtest/fil... File build/android/pylib/gtest/filter/base_unittests_disabled (left): https://codereview.chromium.org/13934025/diff/1/build/android/pylib/gtest/fil... build/android/pylib/gtest/filter/base_unittests_disabled:20: FileUtilProxyTest.Touch On 2013/04/25 01:16:49, Nico wrote: > Doesn't this reenable the test on all platforms? No, this file is android specific. The test runner uses this file to filter out tests. This test is already enabled on other platforms.
lgtm
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nileshagrawal@chromium.org/13934025/1
Presubmit check for 13934025-1 failed and returned exit status 1.
INFO:root:Found 2 file(s).
INFO:PRESUBMIT:Skipping pylint: no matching changes.
Running presubmit commit checks ...
Running /b/commit-queue/workdir/chromium/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/base/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/build/android/PRESUBMIT.py
Running
/b/commit-queue/workdir/chromium/build/android/buildbot/tests/bb_run_bot_test.py
** Presubmit ERRORS **
Missing LGTM from an OWNER for these files:
base/platform_file_unittest.cc
Presubmit checks took 3.1s to calculate.
Adding Mark for base/
ping..
Adding willchan for base/. PTAL
Adding jar for base.
I think you can tbr this change.
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nileshagrawal@chromium.org/13934025/1
https://codereview.chromium.org/13934025/diff/1/build/android/pylib/gtest/fil... File build/android/pylib/gtest/filter/base_unittests_disabled (left): https://codereview.chromium.org/13934025/diff/1/build/android/pylib/gtest/fil... build/android/pylib/gtest/filter/base_unittests_disabled:20: FileUtilProxyTest.Touch On 2013/04/25 01:19:20, nilesh wrote: > On 2013/04/25 01:16:49, Nico wrote: > > Doesn't this reenable the test on all platforms? > > No, this file is android specific. The test runner uses this file to filter out > tests. > This test is already enabled on other platforms. I couldn't spot the android-only dependency you cited. Where should I look to see that?
https://codereview.chromium.org/13934025/diff/1/build/android/pylib/gtest/fil... File build/android/pylib/gtest/filter/base_unittests_disabled (left): https://codereview.chromium.org/13934025/diff/1/build/android/pylib/gtest/fil... build/android/pylib/gtest/filter/base_unittests_disabled:20: FileUtilProxyTest.Touch On 2013/04/29 17:52:41, jar wrote: > On 2013/04/25 01:19:20, nilesh wrote: > > On 2013/04/25 01:16:49, Nico wrote: > > > Doesn't this reenable the test on all platforms? > > > > No, this file is android specific. The test runner uses this file to filter > out > > tests. > > This test is already enabled on other platforms. > > I couldn't spot the android-only dependency you cited. Where should I look to > see that? In the path: build/android/pylib/gtest/filter/base_unittests_disabled
https://codereview.chromium.org/13934025/diff/1/build/android/pylib/gtest/fil... File build/android/pylib/gtest/filter/base_unittests_disabled (left): https://codereview.chromium.org/13934025/diff/1/build/android/pylib/gtest/fil... build/android/pylib/gtest/filter/base_unittests_disabled:20: FileUtilProxyTest.Touch On 2013/04/29 17:52:41, jar wrote: > On 2013/04/25 01:19:20, nilesh wrote: > > On 2013/04/25 01:16:49, Nico wrote: > > > Doesn't this reenable the test on all platforms? > > > > No, this file is android specific. The test runner uses this file to filter > out > > tests. > > This test is already enabled on other platforms. > > I couldn't spot the android-only dependency you cited. Where should I look to > see that? https://code.google.com/p/chromium/codesearch#chromium/src/build/android/pyli... on how the android gtest runner uses this file for disabling tests. This file is not used for other platforms. AFAIK, other platforms disable tests using the DISABLED_ prefix in the unittest file. Android disables many more tests using these _disabled files.
Patch set 1 LGTM
Message was sent while issue was closed.
Change committed as 197099 |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
