Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Unified Diff: ui/keyboard/keyboard_controller.h

Issue 13932030: Delayed loading of the virtual keyboard. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix failing test Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/base/ime/mock_input_method.h ('k') | ui/keyboard/keyboard_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/keyboard/keyboard_controller.h
diff --git a/ui/keyboard/keyboard_controller.h b/ui/keyboard/keyboard_controller.h
index 1a2b18226ed761f472928429e772661ca8fd6147..ca7d0ada03ee37eccecc99ebc2fa492b1507349b 100644
--- a/ui/keyboard/keyboard_controller.h
+++ b/ui/keyboard/keyboard_controller.h
@@ -16,15 +16,17 @@ class Window;
}
namespace ui {
+class InputMethod;
class TextInputClient;
}
namespace keyboard {
class KeyboardControllerProxy;
+class KeyboardLayoutManager;
-// Provides control of the virtual keyboard, including providing a container,
-// managing object lifetimes and controlling visibility.
+// Provides control of the virtual keyboard, including providing a container
+// and controlling visibility.
class KEYBOARD_EXPORT KeyboardController : public ui::InputMethodObserver,
public aura::WindowObserver {
public:
@@ -36,18 +38,24 @@ class KEYBOARD_EXPORT KeyboardController : public ui::InputMethodObserver,
// It is the responsibility of the caller to Show() the returned window.
aura::Window* GetContainerWindow();
- // InputMethodObserver overrides
- virtual void OnTextInputStateChanged(
- const ui::TextInputClient* client) OVERRIDE;
-
private:
+ // For access to Observer methods for simulation.
+ friend class KeyboardControllerTest;
+
// aura::WindowObserver overrides
virtual void OnWindowParentChanged(aura::Window* window,
aura::Window* parent) OVERRIDE;
virtual void OnWindowDestroying(aura::Window* window) OVERRIDE;
+ // InputMethodObserver overrides
+ virtual void OnTextInputStateChanged(
+ const ui::TextInputClient* client) OVERRIDE;
+ virtual void OnInputMethodDestroyed(
+ const ui::InputMethod* input_method) OVERRIDE;
+
scoped_ptr<KeyboardControllerProxy> proxy_;
aura::Window* container_;
+ ui::InputMethod* input_method_;
DISALLOW_COPY_AND_ASSIGN(KeyboardController);
};
« no previous file with comments | « ui/base/ime/mock_input_method.h ('k') | ui/keyboard/keyboard_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698