Set the initial resolution of an RDP session to the client screen resolution if it is available.

remoting/webapp/client_session.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * Class handling creation and teardown of a remoting client session.
  *
  * The ClientSession class controls lifetime of the client plugin
  * object and provides the plugin with the functionality it needs to
@@ skipping 210 matching lines @@
     remoting.ClientSession.ConnectionError.NONE;
 
 /**
  * The id of the client plugin
  *
  * @const
  */
 remoting.ClientSession.prototype.PLUGIN_ID = 'session-client-plugin';
 
 /**
+ * Set of capabilities for which hasCapability_() can be used to test.
+ *
+ * @enum {string}
+ */
+remoting.ClientSession.Capability = {
+  SEND_INITIAL_RESOLUTION: 'sendInitialResolution'

[Jamie, 2013/04/15 23:40:23]

These capabilities should be commented somewhere. Here seems as good a place as
any.

[alexeypa (please no reviews), 2013/04/15 23:56:31]

Done.

+};
+
+/**
+ * The set of capabilities negotiated between the client and host.
+ * @type {Array.<string>}
+ * @private
+ */
+remoting.ClientSession.prototype.capabilities_ = null;
+
+/**
+ * @param {remoting.ClientSession.Capability} capability The capability to test
+ *     for.
+ * @return {boolean} True if the capability has been negotiated between
+ *     the client and host.
+ * @private
+ */
+remoting.ClientSession.prototype.hasCapability_ = function(capability) {
+  if (this.capabilities_ == null)
+    return false;
+
+  return this.capabilities_.indexOf(capability) > -1;
+};
+
+/**
  * @param {Element} container The element to add the plugin to.
  * @param {string} id Id to use for the plugin element .
  * @return {remoting.ClientPlugin} Create plugin object for the locally
  * installed plugin.
  */
 remoting.ClientSession.prototype.createClientPlugin_ = function(container, id) {
   var plugin = /** @type {remoting.ViewerPlugin} */
       document.createElement('embed');
 
   plugin.id = id;
@@ skipping 121 matching lines @@
   this.plugin.onDebugMessageHandler = function(msg) {
     console.log('plugin: ' + msg);
   };
 
   this.plugin.onConnectionStatusUpdateHandler =
       this.onConnectionStatusUpdate_.bind(this);
   this.plugin.onConnectionReadyHandler =
       this.onConnectionReady_.bind(this);
   this.plugin.onDesktopSizeUpdateHandler =
       this.onDesktopSizeChanged_.bind(this);
+  this.plugin.onSetCapabilitiesHandler =
+      this.onSetCapabilities_.bind(this);
 
   this.connectPluginToWcs_();
 };
 
 /**
  * Deletes the <embed> element from the container, without sending a
  * session_terminate request.  This is to be called when the session was
  * disconnected by the Host.
  *
  * @return {void} Nothing.
@@ skipping 372 matching lines @@
  */
 remoting.ClientSession.prototype.onConnectionReady_ = function(ready) {
   if (!ready) {
     this.plugin.element().classList.add("session-client-inactive");
   } else {
     this.plugin.element().classList.remove("session-client-inactive");
   }
 }
 
 /**
+ * This is a callback that gets called when the plugin report capabilities
+ * negotiated with the host.

[Jamie, 2013/04/15 23:40:23]

This could be more simply phrased: "Called when the client-host capabilities
negotiation is complete."

[alexeypa (please no reviews), 2013/04/15 23:56:31]

Done.

+ *
+ * @param {!Array.<string>} capabilities The set of capabilities negotiated
+ *     between the client and host.
+ * @return {void} Nothing.
+ * @private
+ */
+remoting.ClientSession.prototype.onSetCapabilities_ = function(capabilities) {
+  if (this.capabilities_ != null) {
+    console.error('ERROR: onSetCapabilities_() is called more than once');

[Jamie, 2013/04/15 23:40:23]

Nit: No need for ERROR--the console shows errors in red to highlight them.

[alexeypa (please no reviews), 2013/04/15 23:56:31]

Done.

+    return;
+  }
+
+  this.capabilities_ = capabilities;
+  if (this.hasCapability_(
+      remoting.ClientSession.Capability.SEND_INITIAL_RESOLUTION)) {
+    this.plugin.notifyClientResolution(window.innerWidth,
+                                       window.innerHeight,
+                                       window.devicePixelRatio);
+  }
+};
+
+/**
  * @private
  * @param {remoting.ClientSession.State} newState The new state for the session.
  * @return {void} Nothing.
  */
 remoting.ClientSession.prototype.setState_ = function(newState) {
   var oldState = this.state;
   this.state = newState;
   var state = this.state;
   if (oldState == remoting.ClientSession.State.CONNECTING) {
     if (this.state == remoting.ClientSession.State.CLOSED) {
@@ skipping 356 matching lines @@
       var lateAdjustment = 1 + (now - expected) / timeout;
       if (!that.scroll_(lateAdjustment * dx, lateAdjustment * dy)) {
         that.bumpScrollTimer_ = window.setTimeout(
             function() { repeatScroll(now + timeout); },
             timeout);
       }
     };
     repeatScroll(new Date().getTime());
   }
 };