Issue 13926002: Always show the NTP apps page

Issue 13926002: Always show the NTP apps page (Closed)

Created:
7 years, 8 months ago by calamity

Modified:
7 years, 8 months ago

Reviewers:
benwells, Evan Stade

CC:
chromium-reviews, dbeam+watch-ntp_chromium.org, estade+watch_chromium.org, arv+watch_chromium.org, pedrosimonetti+watch_chromium.org, chrome-apps-syd-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Always show the NTP apps page Previously the NTP apps page would not show if the app launcher was installed. Now it will show regardless. This patch also restores apps to chrome://apps when the app launcher is installed. BUG=225371 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194768

Patch Set 1 #

Total comments: 2

Patch Set 2 : IWYU #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -39 lines)			Patch
M	chrome/browser/resources/ntp4/new_tab.js	View		2 chunks	+0 lines, -11 lines	0 comments	Download
M	chrome/browser/ui/webui/ntp/new_tab_page_handler.h	View		1 chunk	+0 lines, -6 lines	0 comments	Download
M	chrome/browser/ui/webui/ntp/new_tab_page_handler.cc	View		2 chunks	+0 lines, -14 lines	0 comments	Download
M	chrome/browser/ui/webui/ntp/new_tab_ui.cc	View	1	3 chunks	+9 lines, -6 lines	0 comments	Download
M	chrome/browser/ui/webui/ntp/ntp_resource_cache.h	View		2 chunks	+4 lines, -1 line	0 comments	Download
M	chrome/browser/ui/webui/ntp/ntp_resource_cache.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

benwells

https://codereview.chromium.org/13926002/diff/1/chrome/browser/ui/webui/ntp/new_tab_ui.cc File chrome/browser/ui/webui/ntp/new_tab_ui.cc (right): https://codereview.chromium.org/13926002/diff/1/chrome/browser/ui/webui/ntp/new_tab_ui.cc#newcode9 chrome/browser/ui/webui/ntp/new_tab_ui.cc:9: #include "apps/app_launcher.h" Can this header be removed?

7 years, 8 months ago (2013-04-09 05:42:57 UTC) #2

calamity

+estade for OWNERS Hey, Could you please review all this ntp stuff. Thanks. https://codereview.chromium.org/13926002/diff/1/chrome/browser/ui/webui/ntp/new_tab_ui.cc File ...

7 years, 8 months ago (2013-04-09 06:50:01 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/calamity@chromium.org/13926002/4001

7 years, 8 months ago (2013-04-18 00:23:43 UTC) #7

Message was sent while issue was closed.

Change committed as 194768

Expand Messages | Collapse Messages