Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 13925006: Declares GetHeightForWidth() for those who need it. (Closed)

Created:
7 years, 8 months ago by Jun Mukai
Modified:
7 years, 8 months ago
Reviewers:
stevenjb, jennyz
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Declares GetHeightForWidth() for those who need it. The default behavior of GetHeightForWidth() just refers GetPreferredSize(), but views::BoxLayout now calculate the height based on the children. However, some views use BoxLayout to layout children but want to keep some specific height by GetPreferredSize(). This doesn't work well anymore, since BoxLayout just ignores the GetPreferredSize() of the host. Those views have to override GetHeightForWidth() to keep the preferred height. BUG=196693 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193800

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -0 lines) Patch
M ash/system/power/power_status_view.h View 1 chunk +1 line, -0 lines 0 comments Download
M ash/system/power/power_status_view.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ash/system/tray/hover_highlight_view.h View 1 chunk +1 line, -0 lines 0 comments Download
M ash/system/tray/hover_highlight_view.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ash/system/tray/special_popup_row.h View 1 chunk +1 line, -0 lines 0 comments Download
M ash/system/tray/special_popup_row.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ash/system/tray/tray_item_view.h View 1 chunk +1 line, -0 lines 0 comments Download
M ash/system/tray/tray_item_view.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ash/system/user/tray_user.cc View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Jun Mukai
7 years, 8 months ago (2013-04-11 18:30:13 UTC) #1
stevenjb
Nice. LGTM
7 years, 8 months ago (2013-04-11 18:34:03 UTC) #2
jennyz
lgtm
7 years, 8 months ago (2013-04-11 18:36:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/13925006/1
7 years, 8 months ago (2013-04-11 20:54:52 UTC) #4
commit-bot: I haz the power
7 years, 8 months ago (2013-04-11 23:24:46 UTC) #5
Message was sent while issue was closed.
Change committed as 193800

Powered by Google App Engine
This is Rietveld 408576698