cc/trees/occlusion_tracker_unittest.cc - Issue 139233002: [#4] Pass gfx structs by const ref (gfx::PointF)

Unified Diff: cc/trees/occlusion_tracker_unittest.cc

Issue 139233002: [#4] Pass gfx structs by const ref (gfx::PointF) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Corrected as per review comments! Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/trees/occlusion_tracker_unittest.cc

diff --git a/cc/trees/occlusion_tracker_unittest.cc b/cc/trees/occlusion_tracker_unittest.cc

index e7f3dffa0e2efb3576fc09387a0ba74bbb17c0d2..6b66c28b70a4ed62a38a95864cfaad51df9aa1f6 100644

--- a/cc/trees/occlusion_tracker_unittest.cc

+++ b/cc/trees/occlusion_tracker_unittest.cc

@@ -200,7 +200,7 @@ template <typename Types> class OcclusionTrackerTest : public testing::Test {

typename Types::HostType* GetHost();

typename Types::ContentLayerType* CreateRoot(const gfx::Transform& transform,

- gfx::PointF position,

+ const gfx::PointF& position,

gfx::Size bounds) {

typename Types::ContentLayerPtrType layer(

Types::CreateContentLayer(GetHost()));

@@ -217,7 +217,7 @@ template <typename Types> class OcclusionTrackerTest : public testing::Test {

typename Types::LayerType* CreateLayer(typename Types::LayerType* parent,

const gfx::Transform& transform,

- gfx::PointF position,

+ const gfx::PointF& position,

gfx::Size bounds) {

typename Types::LayerPtrType layer(Types::CreateLayer(GetHost()));

typename Types::LayerType* layer_ptr = layer.get();

@@ -228,7 +228,7 @@ template <typename Types> class OcclusionTrackerTest : public testing::Test {

typename Types::LayerType* CreateSurface(typename Types::LayerType* parent,

const gfx::Transform& transform,

- gfx::PointF position,

+ const gfx::PointF& position,

gfx::Size bounds) {

typename Types::LayerType* layer =

CreateLayer(parent, transform, position, bounds);

@@ -239,7 +239,7 @@ template <typename Types> class OcclusionTrackerTest : public testing::Test {

typename Types::ContentLayerType* CreateDrawingLayer(

typename Types::LayerType* parent,

const gfx::Transform& transform,

- gfx::PointF position,

+ const gfx::PointF& position,

gfx::Size bounds,

bool opaque) {

typename Types::ContentLayerPtrType layer(

@@ -264,7 +264,7 @@ template <typename Types> class OcclusionTrackerTest : public testing::Test {

typename Types::LayerType* CreateReplicaLayer(

typename Types::LayerType* owning_layer,

const gfx::Transform& transform,

- gfx::PointF position,

+ const gfx::PointF& position,

gfx::Size bounds) {

typename Types::ContentLayerPtrType layer(

Types::CreateContentLayer(GetHost()));

@@ -288,7 +288,7 @@ template <typename Types> class OcclusionTrackerTest : public testing::Test {

typename Types::ContentLayerType* CreateDrawingSurface(

typename Types::LayerType* parent,

const gfx::Transform& transform,

- gfx::PointF position,

+ const gfx::PointF& position,

gfx::Size bounds,

bool opaque) {

typename Types::ContentLayerType* layer =

@@ -413,7 +413,7 @@ template <typename Types> class OcclusionTrackerTest : public testing::Test {

void SetBaseProperties(typename Types::LayerType* layer,

const gfx::Transform& transform,

- gfx::PointF position,

+ const gfx::PointF& position,

gfx::Size bounds) {

layer->SetTransform(transform);

layer->SetSublayerTransform(gfx::Transform());

@@ -424,14 +424,14 @@ template <typename Types> class OcclusionTrackerTest : public testing::Test {

void SetProperties(Layer* layer,

const gfx::Transform& transform,

- gfx::PointF position,

+ const gfx::PointF& position,

gfx::Size bounds) {

SetBaseProperties(layer, transform, position, bounds);

}

void SetProperties(LayerImpl* layer,

const gfx::Transform& transform,

- gfx::PointF position,

+ const gfx::PointF& position,

gfx::Size bounds) {

SetBaseProperties(layer, transform, position, bounds);

« no previous file with comments | « cc/trees/layer_tree_host_unittest_occlusion.cc ('k') | no next file » | no next file with comments »