Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 13923007: Remove --allow-request-os-file-handle option (Closed)

Created:
7 years, 8 months ago by hamaji
Modified:
7 years, 8 months ago
Reviewers:
yzshen1, jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, kinuko, Yusuke Sato
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Remove --allow-request-os-file-handle option We don't need whitelist anymore thanks to https://chromiumcodereview.appspot.com/13508005 TEST=browser_tests, trybots BUG=224753 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=196110

Patch Set 1 #

Patch Set 2 : remove unnecessary #include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -126 lines) Patch
M chrome/browser/chrome_content_browser_client.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client.h View 4 chunks +0 lines, -9 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 1 3 chunks +0 lines, -40 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client_unittest.cc View 1 chunk +0 lines, -55 lines 0 comments Download
M content/public/renderer/content_renderer_client.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/public/renderer/content_renderer_client.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M content/renderer/pepper/pepper_file_io_host.cc View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
hamaji
7 years, 8 months ago (2013-04-22 07:26:54 UTC) #1
jam
lgtm
7 years, 8 months ago (2013-04-22 21:38:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hamaji@chromium.org/13923007/3001
7 years, 8 months ago (2013-04-24 02:46:24 UTC) #3
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=121299
7 years, 8 months ago (2013-04-24 03:48:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hamaji@chromium.org/13923007/3001
7 years, 8 months ago (2013-04-24 09:11:48 UTC) #5
commit-bot: I haz the power
7 years, 8 months ago (2013-04-24 10:30:49 UTC) #6
Message was sent while issue was closed.
Change committed as 196110

Powered by Google App Engine
This is Rietveld 408576698