Issue 13923003: Always require exact maps.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13923003: Always require exact maps. (Closed)

Created:
7 years, 8 months ago by Toon Verwaest

Modified:
7 years, 7 months ago

Reviewers:
danno

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+51 lines, -131 lines)			Patch
M	src/arm/lithium-codegen-arm.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	src/arm/lithium-codegen-arm.cc	View	4 chunks	+5 lines, -10 lines	0 comments	Download
M	src/arm/macro-assembler-arm.h	View	2 chunks	+3 lines, -6 lines	0 comments	Download
M	src/arm/macro-assembler-arm.cc	View	2 chunks	+5 lines, -22 lines	0 comments	Download
M	src/arm/stub-cache-arm.cc	View	5 chunks	+5 lines, -6 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View	4 chunks	+5 lines, -6 lines	0 comments	Download
M	src/ia32/macro-assembler-ia32.h	View	2 chunks	+2 lines, -4 lines	0 comments	Download
M	src/ia32/macro-assembler-ia32.cc	View	1 chunk	+3 lines, -20 lines	0 comments	Download
M	src/ia32/stub-cache-ia32.cc	View	5 chunks	+5 lines, -8 lines	0 comments	Download
M	src/objects.h	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View	4 chunks	+5 lines, -6 lines	0 comments	Download
M	src/x64/macro-assembler-x64.h	View	2 chunks	+2 lines, -4 lines	0 comments	Download
M	src/x64/macro-assembler-x64.cc	View	1 chunk	+3 lines, -20 lines	0 comments	Download
M	src/x64/stub-cache-x64.cc	View	5 chunks	+5 lines, -8 lines	0 comments	Download

Total messages: 3 (0 generated)

Toon Verwaest

PTAL. This simplifies/unifies CheckMaps, which is a prerequisite for generic monomorphic/polymorphic ICs. Performance should be ...

7 years, 8 months ago (2013-04-11 11:08:44 UTC) #1

danno

lgtm, but please don't land until Michael's transition work is finished, since it will likely ...

7 years, 8 months ago (2013-04-23 07:35:29 UTC) #2

Toon Verwaest

7 years, 7 months ago (2013-05-23 09:19:31 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r14768 (presubmit successful).