Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(572)

Unified Diff: content/renderer/render_widget.cc

Issue 1391843006: Embed keyboard shortcut bit in WebKeyboardEvent (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Test Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_widget.cc
diff --git a/content/renderer/render_widget.cc b/content/renderer/render_widget.cc
index 78e5df11a24cc7577e4b48c5d18a89dd7e95aa90..fc8c8d026818ebf5846c55eb9c3b82ead2bc8d33 100644
--- a/content/renderer/render_widget.cc
+++ b/content/renderer/render_widget.cc
@@ -1044,8 +1044,7 @@ void RenderWidget::OnSwapBuffersComplete() {
}
void RenderWidget::OnHandleInputEvent(const blink::WebInputEvent* input_event,
- const ui::LatencyInfo& latency_info,
- bool is_keyboard_shortcut) {
+ const ui::LatencyInfo& latency_info) {
if (!input_event)
return;
base::AutoReset<bool> handling_input_event_resetter(&handling_input_event_,
@@ -1157,8 +1156,10 @@ void RenderWidget::OnHandleInputEvent(const blink::WebInputEvent* input_event,
// If this RawKeyDown event corresponds to a browser keyboard shortcut and
// it's not processed by webkit, then we need to suppress the upcoming Char
// events.
- if (!processed && is_keyboard_shortcut)
+ if (!processed && input_event->type == WebInputEvent::RawKeyDown &&
tdresser 2015/10/13 13:19:47 I have a slight preference for: bool is_keyboard_
jdduke (slow) 2015/10/13 16:13:03 Done.
+ static_cast<const WebKeyboardEvent*>(input_event)->isBrowserShortcut) {
suppress_next_char_events_ = true;
+ }
InputEventAckState ack_result = processed ?
INPUT_EVENT_ACK_STATE_CONSUMED : INPUT_EVENT_ACK_STATE_NOT_CONSUMED;

Powered by Google App Engine
This is Rietveld 408576698