Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 13918004: Change first run strings from "omnibox data" -> "history" (Closed)

Created:
7 years, 8 months ago by gone
Modified:
7 years, 8 months ago
Reviewers:
Yusuf, Dan Beam, newt (away)
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Change first run strings from "omnibox data" -> "history" Changes the string and breaks it apart for the Android UI. BUG=180962 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195063

Patch Set 1 #

Total comments: 5

Patch Set 2 : Renaming strings #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -5 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +6 lines, -3 lines 0 comments Download
M chrome/browser/resources/about_welcome_android/about_welcome_android.html View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/welcome_ui_android.cc View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 15 (0 generated)
gone
Merging some strings from downstream and upstream.
7 years, 8 months ago (2013-04-11 21:03:05 UTC) #1
gone
On 2013/04/11 21:03:05, dfalcantara wrote: > Merging some strings from downstream and upstream. Yusuf, newt, ...
7 years, 8 months ago (2013-04-15 22:39:20 UTC) #2
newt (away)
lgtm You're planning on removing the duplicates of these strings from the Java side, right?
7 years, 8 months ago (2013-04-15 22:47:27 UTC) #3
gone
On 2013/04/15 22:47:27, newt wrote: > lgtm > > You're planning on removing the duplicates ...
7 years, 8 months ago (2013-04-15 22:48:01 UTC) #4
newt (away)
believe in yourself
7 years, 8 months ago (2013-04-15 22:48:57 UTC) #5
Dan Beam
also, why not put the HTML into the translation itself? it would allow changing the ...
7 years, 8 months ago (2013-04-15 22:58:36 UTC) #6
gone
On 2013/04/15 22:58:36, Dan Beam wrote: > also, why not put the HTML into the ...
7 years, 8 months ago (2013-04-15 23:00:59 UTC) #7
Yusuf
lgtm
7 years, 8 months ago (2013-04-15 23:14:54 UTC) #8
Dan Beam
I don't think suffixing with _1 and _2 are good ways to differentiate messages. Imagine ...
7 years, 8 months ago (2013-04-16 01:46:37 UTC) #9
gone
https://chromiumcodereview.appspot.com/13918004/diff/1/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://chromiumcodereview.appspot.com/13918004/diff/1/chrome/app/generated_resources.grd#newcode10029 chrome/app/generated_resources.grd:10029: + <message name="IDS_FIRSTRUN_SIGNED_IN_PART_1" desc="Message informing the user that they ...
7 years, 8 months ago (2013-04-16 18:29:19 UTC) #10
Dan Beam
lgtm
7 years, 8 months ago (2013-04-16 21:47:25 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dfalcantara@chromium.org/13918004/10001
7 years, 8 months ago (2013-04-18 17:41:36 UTC) #12
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-18 18:36:48 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dfalcantara@chromium.org/13918004/10001
7 years, 8 months ago (2013-04-18 21:25:26 UTC) #14
commit-bot: I haz the power
7 years, 8 months ago (2013-04-19 03:18:50 UTC) #15
Message was sent while issue was closed.
Change committed as 195063

Powered by Google App Engine
This is Rietveld 408576698