Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 13913025: Add chrome.isolate and chrome_run gyp target. (Closed)

Created:
7 years, 8 months ago by M-A Ruel
Modified:
7 years, 8 months ago
Reviewers:
Nico, csharp
CC:
chromium-reviews, Vadim Sh.
Visibility:
Public.

Description

Add chrome.isolate and chrome_run gyp target. This permits a user to archive a working chrome build on isolateserver for downloading it elsewhere. Note that the actual list of files listed chrome.isolate hasn't been verified but I prefer to commit it as-is and check each OS afterward. In particular, this new chrome_run target is not included in chromium_swarm_tests. Command to archive is: ninja -C out/Release chrome_run python tools/swarm_client/isolate.py hashtable \ -s out/Release/chrome.isolated \ -o https://isolateserver-dev.appspot.com/ sha1sum out/Release/chrome.isolated Command to download is: python tools/swarm_client/run_isolated.py \ -r https://isolateserver-dev.appspot.com/content/retrieve/default-gzip/ \ -H <hash got from sha1sum command above>/ \ --download <path to download files> Note that the same command can be used on all OSes, except for sha1sum on Windows. R=csharp@chromium.org BUG=98636 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194010

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -30 lines) Patch
A + chrome/chrome.isolate View 2 chunks +33 lines, -30 lines 0 comments Download
M chrome/chrome_exe.gypi View 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
M-A Ruel
Note that I don't specify a command here, since we don't want it to be ...
7 years, 8 months ago (2013-04-09 22:02:03 UTC) #1
csharp
lgtm Would the plan be to then include this file for the other isolate files ...
7 years, 8 months ago (2013-04-10 13:09:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/13913025/1
7 years, 8 months ago (2013-04-10 14:01:00 UTC) #3
commit-bot: I haz the power
Presubmit check for 13913025-1 failed and returned exit status 1. INFO:root:Found 2 file(s). Running presubmit ...
7 years, 8 months ago (2013-04-10 14:01:05 UTC) #4
M-A Ruel
On 2013/04/10 13:09:03, csharp wrote: > lgtm > > Would the plan be to then ...
7 years, 8 months ago (2013-04-10 17:24:15 UTC) #5
M-A Ruel
+ Nico for OWNERS.
7 years, 8 months ago (2013-04-10 17:25:20 UTC) #6
Nico
lgtm stamp, but you really should have a tracking bug for this isolate stuff
7 years, 8 months ago (2013-04-11 05:02:28 UTC) #7
M-A Ruel
On 2013/04/11 05:02:28, Nico wrote: > lgtm stamp, but you really should have a tracking ...
7 years, 8 months ago (2013-04-12 16:06:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/13913025/1
7 years, 8 months ago (2013-04-12 16:06:23 UTC) #9
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=116790
7 years, 8 months ago (2013-04-12 19:27:46 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/13913025/1
7 years, 8 months ago (2013-04-12 20:38:35 UTC) #11
commit-bot: I haz the power
7 years, 8 months ago (2013-04-12 20:58:32 UTC) #12
Message was sent while issue was closed.
Change committed as 194010

Powered by Google App Engine
This is Rietveld 408576698