Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 13913018: Acknowledge invalidations from DriveFileSyncService. (Closed)

Created:
7 years, 8 months ago by dcheng
Modified:
7 years, 8 months ago
Reviewers:
kinuko, msw
CC:
chromium-reviews, tzik+watch_chromium.org, kinuko+watch, msw, calvinlo
Visibility:
Public.

Description

Acknowledge invalidations from DriveFileSyncService. In r186079, local invalidations and acknowledgements were fully implemented. This means that if an InvalidationHandler doesn't acknowledge invalidations that it receives, it will receive wake up pings periodically afterwards. BUG=180693 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193410

Patch Set 1 #

Total comments: 4

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M chrome/browser/sync_file_system/drive_file_sync_service.cc View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
dcheng
7 years, 8 months ago (2013-04-09 18:20:54 UTC) #1
msw
https://codereview.chromium.org/13913018/diff/1/chrome/browser/sync_file_system/drive_file_sync_service.cc File chrome/browser/sync_file_system/drive_file_sync_service.cc (right): https://codereview.chromium.org/13913018/diff/1/chrome/browser/sync_file_system/drive_file_sync_service.cc#newcode344 chrome/browser/sync_file_system/drive_file_sync_service.cc:344: // TODO(msw): Unit tests do not provide profiles; see ...
7 years, 8 months ago (2013-04-09 18:28:29 UTC) #2
dcheng
Oops, I should have looked at the actual bug. Sorry. https://codereview.chromium.org/13913018/diff/1/chrome/browser/sync_file_system/drive_file_sync_service.cc File chrome/browser/sync_file_system/drive_file_sync_service.cc (right): https://codereview.chromium.org/13913018/diff/1/chrome/browser/sync_file_system/drive_file_sync_service.cc#newcode344 ...
7 years, 8 months ago (2013-04-09 18:32:04 UTC) #3
kinuko
lgtm
7 years, 8 months ago (2013-04-10 01:49:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/13913018/5001
7 years, 8 months ago (2013-04-10 15:37:20 UTC) #5
commit-bot: I haz the power
7 years, 8 months ago (2013-04-10 17:35:38 UTC) #6
Message was sent while issue was closed.
Change committed as 193410

Powered by Google App Engine
This is Rietveld 408576698