Issue 13913012: Get rid of GetResourceList for ChangeListLoader::SearchFromServer method.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13913012: Get rid of GetResourceList for ChangeListLoader::SearchFromServer method. (Closed)

Created:
7 years, 8 months ago by hidehiko

Modified:
7 years, 8 months ago

Reviewers:
hashimoto, kinaba

CC:
chromium-reviews, tfarina, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Get rid of GetResourceList for ChangeListLoader::SearchFromServer method. GetResourceList is being deprecated along with Drive API v2 migration. This CL replaces it with new methods Schedule and ContinueGetResourceList. BUG=160932 TEST=Ran unit_tests and tested manually. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193385

Patch Set 1 : #

Patch Set 2 : rebase #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -10 lines)			Patch
	M	chrome/browser/chromeos/drive/change_list_loader.h	View	1	2 chunks	+11 lines, -3 lines	0 comments	Download
	M	chrome/browser/chromeos/drive/change_list_loader.cc	View	1	2 chunks	+35 lines, -7 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

hidehiko

This CL is based on 13450006 Thank you for your review in advance, - hidehiko

7 years, 8 months ago (2013-04-09 15:04:42 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hidehiko@chromium.org/13913012/6001

7 years, 8 months ago (2013-04-10 10:54:51 UTC) #4

Message was sent while issue was closed.

Change committed as 193385

Expand Messages | Collapse Messages