Polished update screen.

Polished update screen.

Corrected elements position.
Animated ellipsis changed to spinner.

TBR=oshima
BUG=154170
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194889

[Nikita (slow), 2013-04-10 04:52:05]

https://codereview.chromium.org/13913011/diff/1/chrome/browser/resources/chro...
File chrome/browser/resources/chromeos/login/oobe.css (right):

https://codereview.chromium.org/13913011/diff/1/chrome/browser/resources/chro...
chrome/browser/resources/chromeos/login/oobe.css:714: .update-throbber {
Makes sense to name it just .throbber and use on other screens like EULA / TPM
instead of existing spinner (the one that is solid blue). We could replace that
another spinner that is used on GAIA screen separately.

https://codereview.chromium.org/13913011/diff/1/chrome/browser/resources/chro...
chrome/browser/resources/chromeos/login/oobe.css:724: @-webkit-keyframes play {
nit: Makes sense to make name more specific like throbber-animation.

https://codereview.chromium.org/13913011/diff/1/chrome/browser/resources/chro...
File chrome/browser/resources/chromeos/login/oobe_screen_update.js (left):

https://codereview.chromium.org/13913011/diff/1/chrome/browser/resources/chro...
chrome/browser/resources/chromeos/login/oobe_screen_update.js:37:
UpdateScreen.startEllipsisAnimation();
I think you should specifically add rule like "display: none"  when screen is
hidden and remove that when screen is shown to prevent animation happening when
visibility is hidden.

[dzhioev (left Google), 2013-04-11 16:08:29]

https://codereview.chromium.org/13913011/diff/1/chrome/browser/resources/chro...
File chrome/browser/resources/chromeos/login/oobe.css (right):

https://codereview.chromium.org/13913011/diff/1/chrome/browser/resources/chro...
chrome/browser/resources/chromeos/login/oobe.css:714: .update-throbber {
On 2013/04/10 04:52:05, Nikita Kostylev wrote:
> Makes sense to name it just .throbber and use on other screens like EULA / TPM
> instead of existing spinner (the one that is solid blue). We could replace
that
> another spinner that is used on GAIA screen separately.
Renamed. I think we shouldn't replace spinner on EULA, because new one looks too
small.

https://codereview.chromium.org/13913011/diff/1/chrome/browser/resources/chro...
chrome/browser/resources/chromeos/login/oobe.css:724: @-webkit-keyframes play {
On 2013/04/10 04:52:05, Nikita Kostylev wrote:
> nit: Makes sense to make name more specific like throbber-animation.

Done.

[Nikita (slow), 2013-04-12 12:54:39]

https://codereview.chromium.org/13913011/diff/1/chrome/browser/resources/chro...
File chrome/browser/resources/chromeos/login/oobe.css (right):

https://codereview.chromium.org/13913011/diff/1/chrome/browser/resources/chro...
chrome/browser/resources/chromeos/login/oobe.css:714: .update-throbber {
On 2013/04/11 16:08:29, dzhioev wrote:
> On 2013/04/10 04:52:05, Nikita Kostylev wrote:
> > Makes sense to name it just .throbber and use on other screens like EULA /
TPM
> > instead of existing spinner (the one that is solid blue). We could replace
> that
> > another spinner that is used on GAIA screen separately.
> Renamed. I think we shouldn't replace spinner on EULA, because new one looks
too
> small.

One that is on TPM dialog is small.

https://codereview.chromium.org/13913011/diff/1/chrome/browser/resources/chro...
File chrome/browser/resources/chromeos/login/oobe_screen_update.js (left):

https://codereview.chromium.org/13913011/diff/1/chrome/browser/resources/chro...
chrome/browser/resources/chromeos/login/oobe_screen_update.js:37:
UpdateScreen.startEllipsisAnimation();
On 2013/04/10 04:52:05, Nikita Kostylev wrote:
> I think you should specifically add rule like "display: none"  when screen is
> hidden and remove that when screen is shown to prevent animation happening
when
> visibility is hidden.

What about this comment?

[dzhioev (left Google), 2013-04-12 16:13:58]

On 2013/04/12 12:54:39, Nikita Kostylev wrote:
>
https://codereview.chromium.org/13913011/diff/1/chrome/browser/resources/chro...
> File chrome/browser/resources/chromeos/login/oobe.css (right):
> 
>
https://codereview.chromium.org/13913011/diff/1/chrome/browser/resources/chro...
> chrome/browser/resources/chromeos/login/oobe.css:714: .update-throbber {
> On 2013/04/11 16:08:29, dzhioev wrote:
> > On 2013/04/10 04:52:05, Nikita Kostylev wrote:
> > > Makes sense to name it just .throbber and use on other screens like EULA /
> TPM
> > > instead of existing spinner (the one that is solid blue). We could replace
> > that
> > > another spinner that is used on GAIA screen separately.
> > Renamed. I think we shouldn't replace spinner on EULA, because new one looks
> too
> > small.
> 
> One that is on TPM dialog is small.
> 
>
https://codereview.chromium.org/13913011/diff/1/chrome/browser/resources/chro...
> File chrome/browser/resources/chromeos/login/oobe_screen_update.js (left):
> 
>
https://codereview.chromium.org/13913011/diff/1/chrome/browser/resources/chro...
> chrome/browser/resources/chromeos/login/oobe_screen_update.js:37:
> UpdateScreen.startEllipsisAnimation();
> On 2013/04/10 04:52:05, Nikita Kostylev wrote:
> > I think you should specifically add rule like "display: none"  when screen
is
> > hidden and remove that when screen is shown to prevent animation happening
> when
> > visibility is hidden.
> 
> What about this comment?

I verified that throbber using no CPU when hidden.

[Nikita (slow), 2013-04-15 13:11:41]

lgtm

[commit-bot: I haz the power, 2013-04-17 23:24:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dzhioev@chromium.org/13913011/5001

[commit-bot: I haz the power, 2013-04-17 23:24:31]

Presubmit check for 13913011-5001 failed and returned exit status 1.

INFO:root:Found 4 file(s).

Running presubmit commit checks ...
Running /b/commit-queue/workdir/chromium/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/chrome/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/chrome/app/theme/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/chrome/browser/resources/PRESUBMIT.py

** Presubmit Messages **
--tbr was specified, skipping OWNERS check

Was the CSS checker useful? Send feedback or hate mail to dbeam@chromium.org.

** Presubmit Warnings **
chrome/browser/resources/chromeos/login/oobe.css:
- Make all zero length terms (i.e. 0px) 0 unless inside of hsl() or part of
@keyframe.
    background-position: 0px;

[commit-bot: I haz the power, 2013-04-18 09:20:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dzhioev@chromium.org/13913011/17001

[commit-bot: I haz the power, 2013-04-18 11:48:49]

Change committed as 194889