Issue 13912024: Fix small race in the sandbox

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13912024: Fix small race in the sandbox (Closed)

Created:
7 years, 8 months ago by cpu_(ooo_6.6-7.5)

Modified:
7 years, 8 months ago

Reviewers:
jschuh

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Fix small race in the sandbox DuplicateHandle with DUPLICATE_CLOSE_SOURCE always closes the handle, right now on failure we close it which means we are closing an invalid handle or closing some other handle in the small race window. Reported by Ashutosh Mehra from Adobe. BUG=233251 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195029

Patch Set 1 #

Patch Set 2 : #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -9 lines)			Patch
M	sandbox/win/src/filesystem_policy.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	sandbox/win/src/named_pipe_policy.cc	View	1	1 chunk	+4 lines, -4 lines	0 comments	Download
M	sandbox/win/src/registry_policy.cc	View	1	2 chunks	+0 lines, -2 lines	0 comments	Download
M	sandbox/win/src/sync_policy.cc	View	1	2 chunks	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cpu@chromium.org/13912024/13001

7 years, 8 months ago (2013-04-18 20:52:02 UTC) #2

Message was sent while issue was closed.

Change committed as 195029

Expand Messages | Collapse Messages