third_party/WebKit/Source/wtf/text/StringImpl.cpp - Issue 1391153004: Make StringImpl's content immutable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/wtf/text/StringImpl.cpp

Issue 1391153004: Make StringImpl's content immutable (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: bug fix: StringBuffer::release returns m_data directly Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/wtf/text/StringImpl.cpp

diff --git a/third_party/WebKit/Source/wtf/text/StringImpl.cpp b/third_party/WebKit/Source/wtf/text/StringImpl.cpp

index 303ee9d1ddd1707c356393bd1b2eabdde4c4fce9..56b81dabfe350d8e03258d5204c07c00f4dc51b7 100644

--- a/third_party/WebKit/Source/wtf/text/StringImpl.cpp

+++ b/third_party/WebKit/Source/wtf/text/StringImpl.cpp

@@ -682,7 +682,7 @@ static PassRefPtr<StringImpl> caseConvert(const UChar* source16, size_t length,

targetLength = converter(data16, targetLength, source16, length, locale, &status);

if (U_SUCCESS(status)) {

if (length > 0)

- output->truncateAssumingIsolated(targetLength);

+ return output->substring(0, targetLength);

return output.release();

}

if (status != U_BUFFER_OVERFLOW_ERROR)

« no previous file with comments | « third_party/WebKit/Source/wtf/text/StringImpl.h ('k') | no next file » | no next file with comments »