Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Issue 13911016: Add README file for WebSockets directory. (Closed)

Created:
7 years, 8 months ago by Adam Rice
Modified:
7 years, 8 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add README file for WebSockets directory. Add a file explaining the two different WebSocket implementations in this directory, and listing which files belong to which implementation. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=196718

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -0 lines) Patch
A net/websockets/README View 1 chunk +43 lines, -0 lines 3 comments Download

Messages

Total messages: 6 (0 generated)
Adam Rice
7 years, 8 months ago (2013-04-25 01:19:53 UTC) #1
tyoshino (SeeGerritForStatus)
https://codereview.chromium.org/13911016/diff/1/net/websockets/README File net/websockets/README (right): https://codereview.chromium.org/13911016/diff/1/net/websockets/README#newcode11 net/websockets/README:11: https://docs.google.com/a/google.com/document/d/1_R6YjCIrm4kikJ3YeapcOU2Keqr3lVUPd-OeaIJ93qQ/preview Access controlled. Please find someway to make it ...
7 years, 8 months ago (2013-04-25 02:50:23 UTC) #2
Adam Rice
https://codereview.chromium.org/13911016/diff/1/net/websockets/README File net/websockets/README (right): https://codereview.chromium.org/13911016/diff/1/net/websockets/README#newcode11 net/websockets/README:11: https://docs.google.com/a/google.com/document/d/1_R6YjCIrm4kikJ3YeapcOU2Keqr3lVUPd-OeaIJ93qQ/preview On 2013/04/25 02:50:23, tyoshino wrote: > Access controlled. ...
7 years, 8 months ago (2013-04-25 05:56:18 UTC) #3
tyoshino (SeeGerritForStatus)
LGTM https://codereview.chromium.org/13911016/diff/1/net/websockets/README File net/websockets/README (right): https://codereview.chromium.org/13911016/diff/1/net/websockets/README#newcode11 net/websockets/README:11: https://docs.google.com/a/google.com/document/d/1_R6YjCIrm4kikJ3YeapcOU2Keqr3lVUPd-OeaIJ93qQ/preview On 2013/04/25 05:56:18, Adam Rice wrote: > ...
7 years, 8 months ago (2013-04-26 09:58:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ricea@chromium.org/13911016/1
7 years, 8 months ago (2013-04-26 09:58:33 UTC) #5
commit-bot: I haz the power
7 years, 8 months ago (2013-04-26 13:27:52 UTC) #6
Message was sent while issue was closed.
Change committed as 196718

Powered by Google App Engine
This is Rietveld 408576698