net/http/http_cache.cc - Issue 13907009: Support optimistic Create and Write operations on the SimpleCache.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_cache.cc

Issue 13907009: Support optimistic Create and Write operations on the SimpleCache. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: gavin comments Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/http/http_cache.cc

diff --git a/net/http/http_cache.cc b/net/http/http_cache.cc

index 27c591d44501dfe84e4cb46e01514692b7a013af..19c7c86f91e6c832caf0fcf8859f476d92b873ad 100644

--- a/net/http/http_cache.cc

+++ b/net/http/http_cache.cc

@@ -722,7 +722,10 @@ int HttpCache::OpenEntry(const std::string& key, ActiveEntry** entry,

int HttpCache::CreateEntry(const std::string& key, ActiveEntry** entry,

Transaction* trans) {

- DCHECK(!FindActiveEntry(key));

+ if (FindActiveEntry(key)) {

+ return ERR_CACHE_RACE;

+ }

WorkItem* item = new WorkItem(WI_CREATE_ENTRY, trans, entry);

PendingOp* pending_op = GetPendingOp(key);