Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 13907003: Re enable DriveFileSystemExtensionApiTest.Search. (Closed)

Created:
7 years, 8 months ago by hidehiko
Modified:
7 years, 8 months ago
Reviewers:
benwells, kinaba
CC:
chromium-reviews, nkostylev+watch_chromium.org, Aaron Boodman, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Re enable DriveFileSystemExtensionApiTest.Search. The failure job was based on broken revision. The root problem is already solved, so this re-enables the test. BUG=229639 TEST=Ran try bot. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193383

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -6 lines) Patch
M chrome/browser/chromeos/extensions/external_filesystem_apitest.cc View 1 1 chunk +1 line, -6 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
hidehiko
Thank you for your review in advance. Ben, could you kindly review this CL as ...
7 years, 8 months ago (2013-04-10 07:28:49 UTC) #1
kinaba
lgtm. could you post a comment on the issue tracker about why it is safe ...
7 years, 8 months ago (2013-04-10 07:32:11 UTC) #2
hidehiko
On 2013/04/10 07:32:11, kinaba wrote: > lgtm. could you post a comment on the issue ...
7 years, 8 months ago (2013-04-10 07:39:13 UTC) #3
benwells
lgtm
7 years, 8 months ago (2013-04-10 08:28:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hidehiko@chromium.org/13907003/7001
7 years, 8 months ago (2013-04-10 08:28:53 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=101682
7 years, 8 months ago (2013-04-10 10:25:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hidehiko@chromium.org/13907003/7001
7 years, 8 months ago (2013-04-10 10:26:48 UTC) #7
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=101705
7 years, 8 months ago (2013-04-10 12:24:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hidehiko@chromium.org/13907003/7001
7 years, 8 months ago (2013-04-10 12:26:34 UTC) #9
commit-bot: I haz the power
7 years, 8 months ago (2013-04-10 14:21:17 UTC) #10
Message was sent while issue was closed.
Change committed as 193383

Powered by Google App Engine
This is Rietveld 408576698