Implement clearFormData for WebViewDatabase

Implement clearFormData for WebViewDatabase

BUG=b/6234236

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=196468

[benm (inactive), 2013-04-23 18:07:47]

https://chromiumcodereview.appspot.com/13902021/diff/4001/android_webview/jav...
File android_webview/java/src/org/chromium/android_webview/FormDatabase.java
(right):

https://chromiumcodereview.appspot.com/13902021/diff/4001/android_webview/jav...
android_webview/java/src/org/chromium/android_webview/FormDatabase.java:14:
public class FormDatabase {
Aw prefix on the name please.

https://chromiumcodereview.appspot.com/13902021/diff/4001/android_webview/nat...
File android_webview/native/form_database.cc (right):

https://chromiumcodereview.appspot.com/13902021/diff/4001/android_webview/nat...
android_webview/native/form_database.cc:29: base::Time begin;
mm, what's the behavior of getting "the null time" here.
Would base::Time::UnixEpoch() suffice?

https://chromiumcodereview.appspot.com/13902021/diff/4001/android_webview/nat...
File android_webview/native/form_database.h (right):

https://chromiumcodereview.appspot.com/13902021/diff/4001/android_webview/nat...
android_webview/native/form_database.h:5: #ifndef
ANDROID_WEBVIEW_NATIVE_FORM_DATABASE_H_
Add AW prefix here and on the filename please.

[sgurun-gerrit only, 2013-04-23 20:49:45]

renamed. PTAL,

https://codereview.chromium.org/13902021/diff/4001/android_webview/java/src/o...
File android_webview/java/src/org/chromium/android_webview/FormDatabase.java
(right):

https://codereview.chromium.org/13902021/diff/4001/android_webview/java/src/o...
android_webview/java/src/org/chromium/android_webview/FormDatabase.java:14:
public class FormDatabase {
On 2013/04/23 18:07:47, benm wrote:
> Aw prefix on the name please

himm there are some classes like cookie_manager, but I guess these are some
oddballs then. will do.

https://codereview.chromium.org/13902021/diff/4001/android_webview/native/for...
File android_webview/native/form_database.cc (right):

https://codereview.chromium.org/13902021/diff/4001/android_webview/native/for...
android_webview/native/form_database.cc:29: base::Time begin;
it is ok. This is also how it is used in the browser:
 case EVERYTHING:
      delete_begin_time = base::Time();
      break;


On 2013/04/23 18:07:47, benm wrote:
> mm, what's the behavior of getting "the null time" here.
> Would base::Time::UnixEpoch() suffice?

https://codereview.chromium.org/13902021/diff/4001/android_webview/native/for...
File android_webview/native/form_database.h (right):

https://codereview.chromium.org/13902021/diff/4001/android_webview/native/for...
android_webview/native/form_database.h:5: #ifndef
ANDROID_WEBVIEW_NATIVE_FORM_DATABASE_H_
On 2013/04/23 18:07:47, benm wrote:
> Add AW prefix here and on the filename please.

Done.

[benm (inactive), 2013-04-24 13:15:38]

https://chromiumcodereview.appspot.com/13902021/diff/13001/android_webview/DEPS
File android_webview/DEPS (right):

https://chromiumcodereview.appspot.com/13902021/diff/13001/android_webview/DE...
android_webview/DEPS:11: "+components/autofill/browser",
Don't think we need top level DEPS for this - it should go into
android_webview/native/DEPS I think.

[sgurun-gerrit only, 2013-04-25 15:42:53]

https://chromiumcodereview.appspot.com/13902021/diff/13001/android_webview/DEPS
File android_webview/DEPS (right):

https://chromiumcodereview.appspot.com/13902021/diff/13001/android_webview/DE...
android_webview/DEPS:11: "+components/autofill/browser",
On 2013/04/24 13:15:38, benm wrote:
> Don't think we need top level DEPS for this - it should go into
> android_webview/native/DEPS I think.

Done.

[benm (inactive), 2013-04-25 17:45:13]

lgtm

[commit-bot: I haz the power, 2013-04-25 17:45:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sgurun@chromium.org/13902021/22001

[commit-bot: I haz the power, 2013-04-25 20:11:37]

Change committed as 196468