[CSSMQ] Implemented support for the scan media feature.

[CSSMQ] Implemented support for the scan media feature.

The scan media feature is only supported for "tv" as per spec. It is
currently not possible to query if a tv is progressive or interlaced.
Progressive is assumed for now.

Also, for media features that take ident values, only accept idents
which are allowed for a given feature.

BUG=236321
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=150487

[kenneth.r.christiansen, 2013-05-15 10:59:03]

lgtm

[apavlov, 2013-05-15 11:29:41]

LGTM with minor nits

https://chromiumcodereview.appspot.com/13896036/diff/1/Source/core/css/MediaQ...
File Source/core/css/MediaQueryEvaluator.cpp (right):

https://chromiumcodereview.appspot.com/13896036/diff/1/Source/core/css/MediaQ...
Source/core/css/MediaQueryEvaluator.cpp:748: // scan only applies to tv media.
Blink mostly inherits the comment style from WebKit:
// Sentence-capitalized comment with a dot.

https://chromiumcodereview.appspot.com/13896036/diff/1/Source/core/css/MediaQ...
Source/core/css/MediaQueryEvaluator.cpp:749: if (equalIgnoringCase(mediaType,
"tv")) {
Early returns are preferred, as they reduce code indentation and improve
readability:

// Scan only applies to tv media.
if (!equalIgnoringCase(mediaType, "tv"))
    return false;

// The rest of the code goes here...

https://chromiumcodereview.appspot.com/13896036/diff/1/Source/core/css/MediaQ...
Source/core/css/MediaQueryEvaluator.cpp:750: 
extra blank line

https://chromiumcodereview.appspot.com/13896036/diff/1/Source/core/css/MediaQ...
Source/core/css/MediaQueryEvaluator.cpp:757: // If a platform interface supply
progressive/interlace info for TVs in the
supply -> supplies

[rune, 2013-05-15 12:33:44]

On 2013/05/15 11:29:41, apavlov wrote:
> LGTM with minor nits
> 
>
https://chromiumcodereview.appspot.com/13896036/diff/1/Source/core/css/MediaQ...
> File Source/core/css/MediaQueryEvaluator.cpp (right):
> 
>
https://chromiumcodereview.appspot.com/13896036/diff/1/Source/core/css/MediaQ...
> Source/core/css/MediaQueryEvaluator.cpp:748: // scan only applies to tv media.
> Blink mostly inherits the comment style from WebKit:
> // Sentence-capitalized comment with a dot.

Fixed.

>
https://chromiumcodereview.appspot.com/13896036/diff/1/Source/core/css/MediaQ...
> Source/core/css/MediaQueryEvaluator.cpp:749: if (equalIgnoringCase(mediaType,
> "tv")) {
> Early returns are preferred, as they reduce code indentation and improve
> readability:

Fixed.

>
https://chromiumcodereview.appspot.com/13896036/diff/1/Source/core/css/MediaQ...
> Source/core/css/MediaQueryEvaluator.cpp:750: 
> extra blank line

Fixed.

>
https://chromiumcodereview.appspot.com/13896036/diff/1/Source/core/css/MediaQ...
> Source/core/css/MediaQueryEvaluator.cpp:757: // If a platform interface supply
> progressive/interlace info for TVs in the
> supply -> supplies

Fixed.

[apavlov, 2013-05-15 12:38:46]

https://chromiumcodereview.appspot.com/13896036/diff/7001/Source/core/css/Med...
File Source/core/css/MediaQueryExp.cpp (right):

https://chromiumcodereview.appspot.com/13896036/diff/7001/Source/core/css/Med...
Source/core/css/MediaQueryExp.cpp:212: if (!featureWithValidIdent(mediaFeature,
static_cast<CSSPrimitiveValue*>(m_value.get())->getIdent()))
Argh, sorry, I totally forgot that a few days ago jchaffraix@ replaced
static_cast<CSS*Value*>()s by toCSS*Value()s, which ASSERT if the cast is wrong.

Please use toCSSPrimitiveValue(m_value.get()) in place of your static_cast, and
we are good to land.

[commit-bot: I haz the power, 2013-05-15 13:00:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rune@opera.com/13896036/10003

[commit-bot: I haz the power, 2013-05-15 14:43:35]

Retried try job too often on linux_layout_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layo...

[commit-bot: I haz the power, 2013-05-16 05:52:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rune@opera.com/13896036/10003

[commit-bot: I haz the power, 2013-05-16 06:10:58]

Change committed as 150487