Make javascript dialogs into top-level windows.

Make javascript dialogs into top-level windows for desktop aura.

Also, correct aura window sizing on desktop aura for Windows.

BUG=230935, 234558, 225252
TEST=NONE (yet)

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=197949

[robertshield, 2013-04-24 16:02:11]

Ben, please could you take a look at this tiny change to the focus controller to
handle top-level modal dialogs popping up?
Thanks!
Robert

[Ben Goodger (Google), 2013-04-25 17:19:28]

https://codereview.chromium.org/13896011/diff/9001/ui/views/corewm/focus_cont...
File ui/views/corewm/focus_controller.cc (right):

https://codereview.chromium.org/13896011/diff/9001/ui/views/corewm/focus_cont...
ui/views/corewm/focus_controller.cc:261: if (!rules_->CanFocusWindow(window))
I'm not happy with this. I've made it thus far that this function used a dcheck
and not an early return because I expected the callers to do validation. Can you
find some other way of doing this?

[robertshield, 2013-04-26 18:40:42]

I found an alternate, nicer way of detecting non-focusable windows.

I also discovered while doing this that the window bounds calculation for
top-level dialogs for desktop aura was incorrect, so I fixed it. Please take a
look at the related change in ui/views/window/native_frame_view.cc.

https://codereview.chromium.org/13896011/diff/9001/ui/views/corewm/focus_cont...
File ui/views/corewm/focus_controller.cc (right):

https://codereview.chromium.org/13896011/diff/9001/ui/views/corewm/focus_cont...
ui/views/corewm/focus_controller.cc:261: if (!rules_->CanFocusWindow(window))
On 2013/04/25 17:19:28, Ben Goodger (Google) wrote:
> I'm not happy with this. I've made it thus far that this function used a
dcheck
> and not an early return because I expected the callers to do validation. Can
you
> find some other way of doing this?

I reverted this bit and instead now perform a check in DNWA::ClearNativeFocus to
see whether the window can be focused.

[Ben Goodger (Google), 2013-04-29 16:21:54]

https://codereview.chromium.org/13896011/diff/23001/ui/views/window/native_fr...
File ui/views/window/native_frame_view.cc (right):

https://codereview.chromium.org/13896011/diff/23001/ui/views/window/native_fr...
ui/views/window/native_frame_view.cc:40: gfx::AcceleratedWidget hwnd =
window->GetAcceleratedWidget();
do we have a util file in views/ui that has a bunch of OS_WIN vs.
USE_AURA/OS_WIN ifdefs? it'd be cool if this could go there.

[robertshield, 2013-04-29 21:49:59]

https://codereview.chromium.org/13896011/diff/23001/ui/views/window/native_fr...
File ui/views/window/native_frame_view.cc (right):

https://codereview.chromium.org/13896011/diff/23001/ui/views/window/native_fr...
ui/views/window/native_frame_view.cc:40: gfx::AcceleratedWidget hwnd =
window->GetAcceleratedWidget();
On 2013/04/29 16:21:55, Ben Goodger (Google) wrote:
> do we have a util file in views/ui that has a bunch of OS_WIN vs.
> USE_AURA/OS_WIN ifdefs? it'd be cool if this could go there.

Moved most of this into hwnd_util_[win|aurawin].cc. Let me know what you think.

[Ben Goodger (Google), 2013-04-30 19:22:45]

lgtm

[commit-bot: I haz the power, 2013-04-30 19:59:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/robertshield@chromium.org/13896011/38001

[commit-bot: I haz the power, 2013-04-30 23:33:32]

Retried try job too often on win_rel for step(s) chrome_frame_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-05-01 17:52:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/robertshield@chromium.org/13896011/38001

[commit-bot: I haz the power, 2013-05-01 18:13:13]

Sorry for I got bad news for ya.
Compile failed with a clobber build on android_clang_dbg.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_cl...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-05-02 17:16:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/robertshield@chromium.org/13896011/38001

[commit-bot: I haz the power, 2013-05-02 18:53:38]

Change committed as 197949